Move Views theme-specific CSS to their respective themes [#1826574]

Problem/Motivation

Currently Views has a specific style sheet for each core theme. Some of the styles are needed for Views, and others duplicate styles that are already produced by the theme.

Proposed resolution

Merge the Views custom styles into to the actual core themes.

Remaining tasks

Each Views custom theme sheet should be added to its respective theme's CSS
After styles have been included with their theme, remove the custom sheets from Views
Refactor the added Views styles accordingly, with special attention paid to style duplication

User interface changes

n/a

API changes

n/a

Comment	File	Size	Author
#9	vdc-1826574-9.patch	24.21 KB	tim.plunkett
#9	interdiff.txt	530 bytes	tim.plunkett
#8	vdc-1826574-6-formatpatch.patch	29.78 KB	dead_arm
#8	vdc-1826574-6.patch	24.1 KB	dead_arm
#6	durpal-1826574-6.patch	30.23 KB	dawehner
#4	drupal-1826574-4.patch	30.24 KB	dawehner
#4	interdiff.txt	1.77 KB	dawehner
#3	vdc-1826574-3.patch	28.47 KB	dead_arm

Comments

Comment #1

dead_arm

she/her

English

commented 30 October 2012 at 00:41

Assigned:

Unassigned

» dead_arm

Working on an issue summary.

Comment #2

yoroy commented 1 November 2012 at 10:13

This will help resolve #1806022: Views' text color does not have sufficient contrast which is a critical. Go for it :)

Comment #3

dead_arm

she/her

English

commented 1 November 2012 at 18:11

Status:

Active

» Needs review

Status	File	Size
new	vdc-1826574-3.patch	28.47 KB

Here's a preliminary patch. Leaving assigned to myself to remove further redundancies.

Comment #4

dawehner

German

commented 1 November 2012 at 20:57

Status	File	Size
new	interdiff.txt	1.77 KB
new	drupal-1826574-4.patch	30.24 KB

Great work!
We could remove some php code if we move the css files, awesome.

Comment #5

1 November 2012 at 23:37

Status:

Needs review

» Needs work

The last submitted patch, drupal-1826574-4.patch, failed testing.

Comment #6

dawehner

German

commented 2 November 2012 at 04:05

Status:

Needs work

» Needs review

Status	File	Size
new	durpal-1826574-6.patch	30.23 KB

Rerolled against tim :p

Comment #7

tim.plunkett

he/him

English

Philadelphia

commented 2 November 2012 at 05:00

+++ b/core/modules/views/views_ui/lib/Drupal/views_ui/ViewFormControllerBase.phpundefined
@@ -66,22 +66,15 @@ public static function getAdminCSS() {
     $theme_key = $GLOBALS['theme'];
     while ($theme_key) {
       // Try to find the admin css file for non-core themes.
-      if (!in_array($theme_key, array('seven', 'bartik'))) {
-        $theme_path = drupal_get_path('theme', $theme_key);
-        // First search in the css directory, then in the root folder of the theme.
-        if (file_exists($theme_path . "/css/views-admin.$theme_key.css")) {
-          $list[$theme_path . "/css/views-admin.$theme_key.css"] = array(
-            'group' => CSS_THEME,
-          );
-        }
-        elseif (file_exists($theme_path . "/views-admin.$theme_key.css")) {
-          $list[$theme_path . "/views-admin.$theme_key.css"] = array(
-            'group' => CSS_THEME,
-          );
-        }
+      $theme_path = drupal_get_path('theme', $theme_key);
+      // First search in the css directory, then in the root folder of the theme.
+      if (file_exists($theme_path . "/css/views-admin.$theme_key.css")) {
+        $list[$theme_path . "/css/views-admin.$theme_key.css"] = array(
+          'group' => CSS_THEME,
+        );
       }
-      else {
-        $list[$module_path . "/css/views-admin.$theme_key.css"] = array(
+      elseif (file_exists($theme_path . "/views-admin.$theme_key.css")) {
+        $list[$theme_path . "/views-admin.$theme_key.css"] = array(
           'group' => CSS_THEME,
         );

All of this code should go away; there is no reason we should assume that non-core themes are used.