Write feature to generate and test stable release for an existing full project.

The project to be considered is - http://git6site.devdrupal.org/project/test_releases

Related issue: #1706892: Project nodes (Your project) - project_nodes_your_project, _your_project_maintainers

Comments

kssundar’s picture

kssundar commented
Assigned: Unassigned » kssundar
Issue tags: +sprint 15

Tagging and assigning

kssundar’s picture

kssundar commented
Title: Project stable release » Project stable release (project_stable_release.feature)
Status: Active » Needs review

Feature created and committed here - http://drupalcode.org/project/doobie.git/commit/621ca58

eliza411’s picture

eliza411 commented

This is passing consistently today. I'll check it when I re-test its companion, but I think we'll be able to remove the @flaky and @wip tags tomorrow :)

eliza411’s picture

eliza411 commented
Status: Needs review » Needs work

It seems like a good idea to check if git vetted user is already a maintainer before setting it to be a maintainer because the test is prone to failure after a test run has been interrupted (which can happen for a variety of reasons).

Since the point of this feature is to ensure the ability to create releases, not the ability to assign maintainership, I think the test should continue rather than fail in either case.

kssundar’s picture

kssundar commented
Issue tags: +retest after next build, +sprint 16

Tagging

kssundar’s picture

kssundar commented
Status: Needs work » Needs review

Updated feature - http://drupalcode.org/project/doobie.git/commit/483e22b and http://drupalcode.org/project/doobie.git/commit/80bad35

kssundar’s picture

kssundar commented
Priority: Major » Critical
Issue tags: +sprint 17

Tagging

kssundar’s picture

kssundar commented

Ported to 7.x - http://drupalcode.org/project/doobie.git/commit/f10b5ef

kssundar’s picture

kssundar commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Priority: Critical » Normal

This is now 7.x

eliza411’s picture

eliza411 commented
Status: Needs review » Reviewed & tested by the community

I added a javascript tag to prevent the following:

  Scenario: Add git vetted user as maintainer           # features/git/project_stable_release.feature:8
    Given I am logged in as "admin test"                # FeatureContext::iAmLoggedInAs()
    When I visit "/node/1791620/maintainers"            # FeatureContext::iVisit()
    And I wait until the page loads                     # FeatureContext::iWaitUntilThePageLoads()
    Then I should see "git vetted user" as a maintainer # FeatureContext::iShouldSeeAsAMaintainer()
      JS scripts execution is not supported by Behat\Mink\Driver\GoutteDriver

This is as good as we can do until D7 Drupal.org is ready for feedback.

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Needs work

This has been working. The test project it depends upon is not present on Git7 today. Should be rechecked after next build

behat features/git/project_stable_release.feature