Comments

chris.smith’s picture

Status: Active » Needs review
StatusFileSize
new2.11 KB
new2.11 KB

Fixed number of comments per page in "Comment settings" content type edit form. Needs Review.

nagba’s picture

Status: Needs review » Needs work

1) Coding style issues, check your patch in the browser, i can see tabs instead of actual spaces in the indentation. The new function's doxygen also does not follow codying style standards.
2) There is a comment stating "Set "Comments per page" setting to textfield so it allows more gradual control over the number of comments to show." and now you are undoing that. I am not sure that is the right approach.

kaidjohnson’s picture

Assigned: Unassigned » kaidjohnson
Status: Needs work » Needs review
StatusFileSize
new2.4 KB

I agree with @nagba.

Here's a solution that corrects the javascript selectors in the fieldset summaries. It also includes a small code standards correction.

firewaller’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch #3 works for me

avpaderno’s picture

Issue summary: View changes
StatusFileSize
new280 KB
avpaderno’s picture

Assigned: kaidjohnson » Unassigned