Misleading documentation for db_rewrite_sql()
Darren Oh - October 11, 2007 - 18:26
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | documentation |
| Category: | bug report |
| Priority: | normal |
| Assigned: | patchnewbie |
| Status: | closed |
Description
The primary table name must be in curly braces, otherwise there will be errors when table prefixes are used.
#1
#2
Committed. Thanks.
#3
Applied to HEAD in CVS commit 84159.
#4
This would be a good patch for someone new to core development.
#5
Patch ported to D6.
#6
Great! Marking for review.
#7
Tested - fantastic!
#8
Committed to 5.x
#9
Fixed in CVS commit 87175.
#10
Should similar changes also be made to _db_rewrite_sql() for consistency?
#11
Automatically closed -- issue fixed for two weeks with no activity.
#12
Actually it looks as though the patch at comment #1 got committed first to D6 (although it was intended for D5) then to D5 and the patch at #5 was never applied.
Here's another patch for D6 based on HEAD. It fixes a couple of excessively long lines in the phpdoc of db_rewrite_sql(), clarifies the instructions further, and does same for _db_rewrite_sql() also.
The doc. for http://api.drupal.org/api/function/hook_db_rewrite_sql should also be updated accordingly but I don't know how to do that!
#13
Indeed, we mostly used table aliases but these were not documented. Thanks for the improvement.
#14
Thanks Gábor.
(Commit #91420.)
#15
Automatically closed -- issue fixed for two weeks with no activity.