Download & Extend
Issues

Misleading documentation for db_rewrite_sql()

Posted by Darren Oh on October 11, 2007 at 6:26pm
Project:Drupal core
Version:6.x-dev
Component:documentation
Category:bug report
Priority:normal
Assigned:patchnewbie
Status:closed (fixed)

Issue Summary

The primary table name must be in curly braces, otherwise there will be errors when table prefixes are used.

Login or register to post comments

Comments

#1

Posted by Darren Oh on October 11, 2007 at 6:27pm
Status:active» needs review
AttachmentSizeStatusTest resultOperations
database.inc-182728.patch832 bytesIgnored: Check issue status.NoneNone

#2

Posted by Dries on October 12, 2007 at 2:20pm
Status:needs review» fixed

Committed. Thanks.

#3

Posted by Darren Oh on October 18, 2007 at 10:53pm
Status:fixed» patch (to be ported)

Applied to HEAD in CVS commit 84159.

#4

Posted by patchnewbie on October 18, 2007 at 11:32pm
Assigned to:Anonymous» patchnewbie

This would be a good patch for someone new to core development.

#5

Posted by hazexp on October 21, 2007 at 1:13pm

Patch ported to D6.

AttachmentSizeStatusTest resultOperations
database_13.patch605 bytesIgnored: Check issue status.NoneNone

#6

Posted by patchnewbie on October 26, 2007 at 9:59pm
Status:patch (to be ported)» needs review

Great! Marking for review.

#7

Posted by fp on October 31, 2007 at 9:37pm
Status:needs review» reviewed & tested by the community

Tested - fantastic!

#8

Posted by drumm on November 7, 2007 at 5:56am
Status:reviewed & tested by the community» fixed

Committed to 5.x

#9

Posted by Darren Oh on November 13, 2007 at 6:23pm

Fixed in CVS commit 87175.

#10

Posted by gpk on November 22, 2007 at 11:23pm

Should similar changes also be made to _db_rewrite_sql() for consistency?

#11

Posted by Anonymous on December 6, 2007 at 11:31pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#12

Posted by gpk on December 8, 2007 at 11:48pm
Version:5.x-dev» 6.x-dev
Status:closed (fixed)» needs review

Actually it looks as though the patch at comment #1 got committed first to D6 (although it was intended for D5) then to D5 and the patch at #5 was never applied.

Here's another patch for D6 based on HEAD. It fixes a couple of excessively long lines in the phpdoc of db_rewrite_sql(), clarifies the instructions further, and does same for _db_rewrite_sql() also.

The doc. for http://api.drupal.org/api/function/hook_db_rewrite_sql should also be updated accordingly but I don't know how to do that!

AttachmentSizeStatusTest resultOperations
database.inc-182728.patch1.93 KBIgnored: Check issue status.NoneNone

#13

Posted by Gábor Hojtsy on December 14, 2007 at 7:16pm
Status:needs review» fixed

Indeed, we mostly used table aliases but these were not documented. Thanks for the improvement.

#14

Posted by gpk on December 15, 2007 at 3:11pm

Thanks Gábor.

(Commit #91420.)

#15

Posted by Anonymous on December 29, 2007 at 3:11pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.