The primary table name must be in curly braces, otherwise there will be errors when table prefixes are used.

CommentFileSizeAuthor
#12 database.inc-182728.patch1.93 KBgpk
#5 database_13.patch605 byteshazexp
#1 database.inc-182728.patch832 bytesdarren oh

Comments

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Needs review
StatusFileSize
new database.inc-182728.patch832 bytes
dries’s picture

dries commented
Status: Needs review » Fixed

Committed. Thanks.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Fixed » Patch (to be ported)

Applied to HEAD in CVS commit 84159.

patchnewbie’s picture

patchnewbie commented
Assigned: Unassigned » patchnewbie

This would be a good patch for someone new to core development.

hazexp’s picture

hazexp commented
StatusFileSize
new database_13.patch605 bytes

Patch ported to D6.

patchnewbie’s picture

patchnewbie commented
Status: Patch (to be ported) » Needs review

Great! Marking for review.

fp’s picture

fp commented
Status: Needs review » Reviewed & tested by the community

Tested - fantastic!

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.x

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

Fixed in CVS commit 87175.

gpk’s picture

gpk commented

Should similar changes also be made to _db_rewrite_sql() for consistency?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

gpk’s picture

gpk commented
Version: 5.x-dev » 6.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new database.inc-182728.patch1.93 KB

Actually it looks as though the patch at comment #1 got committed first to D6 (although it was intended for D5) then to D5 and the patch at #5 was never applied.

Here's another patch for D6 based on HEAD. It fixes a couple of excessively long lines in the phpdoc of db_rewrite_sql(), clarifies the instructions further, and does same for _db_rewrite_sql() also.

The doc. for http://api.drupal.org/api/function/hook_db_rewrite_sql should also be updated accordingly but I don't know how to do that!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Indeed, we mostly used table aliases but these were not documented. Thanks for the improvement.

gpk’s picture

gpk commented

Thanks Gábor.

(Commit #91420.)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.