Based on Integrate Order Revisions with Views:

The product revision system is in place, but there's currently no way to view changes.

CommentFileSizeAuthor
#1 commerce-integrate_product_revisions_with_views-1827292-1.patch21.68 KBcvangysel

Comments

cvangysel’s picture

cvangysel commented
Assigned: Unassigned » cvangysel
Status: Active » Needs review
StatusFileSize
new commerce-integrate_product_revisions_with_views-1827292-1.patch21.68 KB

Attached to this post is a patch that integrates product revisions with views and adds a revisions tab to the admin product view.

rcross’s picture

rcross commented
Status: Needs review » Needs work

looks ok to me. I would suggest making the default order to be by revision id. otherwise good to go.

brunorios1’s picture

brunorios1 commented

looks ok to me too...

rcross’s picture

rcross commented
Status: Needs work » Reviewed & tested by the community
rszrama’s picture

rszrama commented
Assigned: cvangysel » Unassigned
Status: Reviewed & tested by the community » Fixed

Agreed with Ryan about the default order and also added in a relationship to the user who created the revision. I'm not a huge fan of the administrative permission based access control - but I don't know a better way to inject access control into the View. Maybe we can consider a custom argument handler for our entities in the future if need be to make it based on permissions / product access. This gets the job done for now, though.

Thanks for the reviews.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/fdf33d4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.