There was hosting_shared.feature file, I renamed it to marketplace_hosting.feature to reflect that it includes tests for all parts of the hosting section. Added/modified some tests (http://drupalcode.org/project/doobie.git/commit/e122c13).

Scenarios for each subsection have a check for number of records under "Other great hosts" e.g.
"And I should see at least "3" records".
We need such checks for WebAds located above "Other great hosts" as well.

CommentFileSizeAuthor
#5 drupal.org-screen-capture.png324.29 KBtvn

Comments

tvn’s picture

tvn commented

Damn Notepad++
Fixing indentation.
http://drupalcode.org/project/doobie.git/commit/2df896d
http://drupalcode.org/project/doobie.git/commit/1beffa9

tvn’s picture

tvn commented

Added missing Then statement http://drupalcode.org/project/doobie.git/commit/ab64f75

pradeeprkara’s picture

pradeeprkara commented

Can you please elaborate:

We need such checks for WebAds located above "Other great hosts" as well.

Couldn't find the location for WebAds.

eliza411’s picture

eliza411 commented

Combined scenarios in commit http://drupalcode.org/project/doobie.git/commit/7927a2d to conform to the Given/When/Then pattern.

tvn’s picture

tvn commented
StatusFileSize
new drupal.org-screen-capture.png324.29 KB

Re: #3, you probably have some sort of Ad blocking enabled in your browser.
Screenshot attached, web ads are right below "Through code contributions or sponsorship of the Drupal Association, these organizations help make Drupal successful."

pradeeprkara’s picture

pradeeprkara commented
Assigned: Unassigned » pradeeprkara
Issue tags: +sprint 16

assigning and tagging

pradeeprkara’s picture

pradeeprkara commented

Added a step to check the number of ads displayed.
Eg:
And I should see at least "5" WebAds

As the ads are pulled through javascript, selenium will be required here and tagged the applicable scenarios with @javascript.

Please review:

http://drupalcode.org/project/doobie.git/commit/f8f33c3
http://drupalcode.org/project/doobie.git/commit/d4b0c1f
http://drupalcode.org/project/doobie.git/commit/5a7c378

tvn’s picture

tvn commented
Status: Active » Needs review

Looks good to me, thank you.

sachin2dhoni’s picture

sachin2dhoni commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Assigned: pradeeprkara » sachin2dhoni
Issue tags: +sprint 17

Ported to 7.x
http://drupalcode.org/project/doobie.git/commit/58032c4

eliza411’s picture

eliza411 commented
Status: Needs review » Reviewed & tested by the community

As ready as it can be until the D7 marketplace pages are printing content.

eliza411’s picture

eliza411 commented
Assigned: sachin2dhoni » tvn
Status: Reviewed & tested by the community » Needs work
Issue tags: +qa, +drupal.org D7

@tvn: Can you update this test to match the expected new behaviors? I'm not sure what they are supposed to be or whether they're finished at this point.

tvn’s picture

tvn commented
Status: Needs work » Fixed

Updated the tests and one step definition.
http://drupalcode.org/project/doobie.git/commit/f77ce92

All scenarios in this feature file pass now. Note that I had to manually adjust one setting on git7site, as it's not automated yet. So after the next rebuild some scenarios will fail till this issue is fixed: #2028957: Update /hosting page on D7

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

.