Audio Recorder

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Problems raised by automated review tools: http://ventral.org/pareview/httpgitdrupalorgsandboxzolexiy1781320git

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Thank you for your reviews. When finishing your review comment also set the issue status either to "needs work" (you found some problems with the project) or "reviewed & tested by the community" (you found no major flaws).

manual review:

1. There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
2. recorder.swf: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org. Same for recorder.js?
3. README.txt: Please take a moment to make your README.txt follow the guidelines for in-project documentation.
4. "module_load_include('inc', 'audio_recorder', 'inc/audio_recorder.widget');": no need to use module_load_include as you are including files from your own module which you already know where they are. Use something like require_once 'mymodule.inc';.
5. audio_recorder_form_alter(): why is that needed for #attributes on node forms? Please add a comment.
6. _audio_recorder_record(): this is hard coded to nodes, but the field should work with any entity type?
7. _audio_recorder_record(: you can use file_munge_filename() to secure the user provided file name.

Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Hi Drucode,

Cool idea. Installed it with no problem. But, i miss a better readme, took me awhile to figure out it was a widget for the File-field type.

Try to write your README.txt according to README files.

Also, have you checked what license recorder.js has? Drupal.org has a rule: "4.2 Ensure the repository does not contain any 3rd party (non-GPL) code."
You should go through the checklist and make sure you have done everything.

Your function "audio_recorder_element_info()" in audio_recorder.module does not create the correct path to my drupal installation which is in a subfolder.
You have:
'data' => array('audioRecorder' => array('swfSrc' => '/' . $path . '/swf/recorder.swf')),
You should remove the slash before $path.

Noticed klausi had written a review while i was writing mine, but i see i have found som extra issues.

Edit: Don't know why the PAReviw bonus got added back, was not my intention.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Added 3 module reviews.