This is a follow-up for #1754354: Node revisions only displays latest revision, that introduced a new Revision relationship. (nid vs. vid) .
However, both relationships have exactly the same descriptions, which is very confusing.

CommentFileSizeAuthor
#5 views_1827602_5_content_revision_description.patch929 bytesjohnv
#1 views_1827602_1_content_revision_description.patch888 bytesjohnv

Comments

johnv’s picture

johnv
Primary language Dutch
commented
Title: Better descriptions for new 'Entity Revision' relationships. » Better descriptions for new 'Content revision' relationships.
StatusFileSize
new views_1827602_1_content_revision_description.patch888 bytes

Please find text suggestions attached.

I use 'historical data' , because that appears in the Fields section, too.
I use 'current' vs. actual, because 'actual' gives me the impression of 'real' rather then 'latest'.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Active » Needs review

See also #1397106: Content (historical data) vs. Content revision in view of type: Content revision.

Status: Needs review » Needs work

The last submitted patch, views_1827602_1_content_revision_description.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ modules/node.views.inc	(working copy)
@@ -482,8 +482,8 @@
-      'title' => t('Content'),

@@ -513,8 +513,8 @@
-      'title' => t('Content'),

Don't change group, and provide a patch in '-p1' format

johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new views_1827602_5_content_revision_description.patch929 bytes

Please find attache a git-style patch.

I haven't changed the contents. IMO the 'title' is not the group, but it is appended to the group.
This is how both relationships handlers look like BEFORE, with original 'title':
RELATIONSHIPS
Content revision: Content
Content revision: Content

And this is how both relationships handlers look like AFTER, with new 'title':
RELATIONSHIPS
Content revision: historical data (Vid)
Content revision: current data (Nid)

kehan’s picture

kehan commented

I tried the patch against 7.x-3.5 and it works for me

johnv’s picture

johnv
Primary language Dutch
commented

#5: views_1827602_5_content_revision_description.patch queued for re-testing.

chris matthews’s picture

chris matthews commented
Issue summary: View changes

The 6 year old patch in #5 to node.views.inc applied cleanly to the latest views 7.x-3.x-dev and if still applicable needs to be reviewed.

Checking patch modules/node.views.inc...
Hunk #1 succeeded at 510 (offset 28 lines).
Hunk #2 succeeded at 542 (offset 28 lines).
Applied patch modules/node.views.inc cleanly.