As suggested in http://drupal.org/node/72487 by moshe weitzman: There's no need to test patches for issues which are in 'fixed' status, as testing of already commited patches is pointless and bound to fail.

(The same applies to "won't fix", "closed", "by design", and perhaps "patch to be ported" - all these contain patches (if any) which will not apply OR are unlikely to be ever committed. I don't know how the current code handle these cases though, so forgive me this note if it's irrelevant.)

Also I saw failed test reports around the issue queue, which were done on .txt files - I think that no sane person attaches a valid patch with .txt extension, but there are lots of other non-patch .txt files. So it might be good to limit testing to only just .patch and .diff files.

Comments

robin monks’s picture

robin monks commented

Ideally, we don't test based on status, since, a lot of time an issue on HEAD is not marked fixed, but rather the version is changed so it can be backported. Ideally we check for "Reversed (or previously applied) patch detected!" in the patch reply to simpletestauto, and we simply don't trigger a followup when that happens.

Robin

JirkaRybka’s picture

JirkaRybka commented

I think it would be best to have BOTH these tests. Check for already applied patch won't catch (possibly very old) "won't fix" patches, nor the mentioned "changed version for backport", which is clearly identified by "patch to be ported" status. I think the mechanism will only benefit from double check.

Amazon’s picture

Amazon commented
Priority: Normal » Critical

Possible duplicate here: http://drupal.org/node/182722

Moving to critical.

boombatower’s picture

boombatower commented
Status: Active » Fixed

Should be fixed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.