Username is always "Anonymous"

This patch fixed my problems. Needs review.

I have the same problem.
But in my case the username is always shown as "Anonymous"

When I switch off that modul everything is alright.
I need some help. Please.

Try the patch and let us know if it works for you.

I encountered the same issue, and can verify that the patch works.

Thanks, it works

Can patch be incorporated in next release?

Patch worked for me too. Thanks.

this patch needs to be applied as it fixed the same issue for me too

the patch works for me too. Add to next release please.

Is there any update on when this patch will be applied to the module?

Patch works

I'm having trouble reproducing this issue. Can anyone provide detailed steps to reproduce?

Here's the STR I'm using and cannot find an issue:

1. Install a bare D7 installation
2. Checkout and enable comment_goodness 1.4
3. Get an anonymous user to post a comment
4. As an administrator, view the node containing the comment and click the "edit" link
5. Change the username and submit the form
6. ... ? ...

The last point is where I'm assuming things go wrong - is it the case that people are seeing the "anonymous" username here still, instead of the actual username that was set by the administrator?

The patch additionally needs to have the function header comment changed back to hook_preprocess_HOOK per https://api.drupal.org/api/drupal/modules%21system%21theme.api.php/funct...

I'm not against making this change if I can verify the actual problem, but at the moment I cannot. There is no obvious reason why the code in comment_goodness would be wrong, given that core uses the same variable here http://cgit.drupalcode.org/drupal/tree/modules/comment/comment.module?h=... . So I'm suspicious that (1) me being unable to reproduce this problem, and (2) that core uses the same pattern as the module might indicate that the problem lies elsewhere.

There may be some module hook ordering issue I guess, but would need more information to be able to determine that - at the moment I can't reproduce the issue (making many assumptions about what the actual issue is).

strangest solution, theme username needs a user object (https://api.drupal.org/api/drupal/includes!theme.inc/function/theme_user...) in account key, not comment

To reproduce:
- Create a comment with an authenticated user
- View the comment, it say's it has been submitted by Anonymous instead of the users name

Patch from #1 works for me. The docu change is unnecessary. For me this is RTBC.

Patch from #1 works for me (I am posting here to remind myself for next time I install this module!)

Also works for me. Thank you!

Can we get this fix committed to the development branch and closed off.

If you're exposing comments as fields I also needed this fix

The module doesn't implement anymore comment_goodness_preprocess_comment(), nor does it use the code the patch is trying to alter.

I apologize: That was the master branch, not the 7.x-1.x branch.