I moved what used to be casestudy.feature into 2 files:
casestudies_featured.feature and casestudies_community.feature. They are just about navigating around section. Renamed casestudy -> casestudies to be consistent with the tags.
http://drupalcode.org/project/doobie.git/commit/114e554

casestudies_community.feature seems ok.

casestudies_featured.feature needs some edits:

1. "Scenario: View case study page"
needs to check that 8 case studies are present on the page

2. "Scenario Outline: Navigate into featured showcase categories"
needs to check that at least 1 case study is present on the page

Comments

tvn’s picture

tvn commented
Title: Update casestudies_feature.feature » Update casestudies_featured.feature
Status: Active » Needs work
kssundar’s picture

kssundar commented
Status: Needs work » Needs review
Issue tags: +sprint 15

This is done - http://drupalcode.org/project/doobie.git/commit/f8c2031

tvn’s picture

tvn commented

Thanks. Both files look good to me.

tvn’s picture

tvn commented
Title: Update casestudies_featured.feature » Update casestudies_featured.feature, casestudies_community.feature

Adjusting title.

kssundar’s picture

kssundar commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Assigned: Unassigned » kssundar
Status: Needs review » Patch (to be ported)
Issue tags: +sprint 17

Needs 7.x update

kssundar’s picture

kssundar commented
Status: Patch (to be ported) » Needs review

Ported to 7.x

casestudies_community.feature - http://drupalcode.org/project/doobie.git/commit/b6e92c7
casestudies_featured.feature - http://drupalcode.org/project/doobie.git/commit/5547726

eliza411’s picture

eliza411 commented

@ksbalajisundar, In your opinion, should we be using the sprintf format for exceptions in this project as well as the DrupalExtension, or is the format here consistent?

kssundar’s picture

kssundar commented

I see that most of the exceptions are in the format throw new Exception("The link '" . $link . "' was not found on the region '" . $region . "'");. Trying to change it to sprintf would be a huge task. As it is consistent here, I prefer not to touch the current format.

If a major cleanup task is taken up in future, then it can be changed to sprintf.

eliza411’s picture

eliza411 commented

Perfect. I just wanted to be sure we'd made an explicit decision, and we have, and I can document that.

eliza411’s picture

eliza411 commented
Component: Feature/Scenarios » Broken site
Status: Needs review » Reviewed & tested by the community

Test appears to be failing properly and the best it can be until D7 Drupal.org is ready for feedback.

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Needs work

Sorry ... one thing I did see that could be improved here:

The step When I click on a case study image is confusing because that function appears to just click the first link in a case study and doesn't check at all if that is an image or not.

It seems like we could just remove the word image from the step and it would better describe what's happening. We're catching broken site behavior with the tests they way they are now. It *is* important to verify the images are appearing, but that seems like it should be a test of its own.

kssundar’s picture

kssundar commented
Status: Needs work » Needs review
Issue tags: +sprint 19

Updated accordingly - http://drupalcode.org/project/doobie.git/commit/43f7721

eliza411’s picture

eliza411 commented
Status: Needs review » Reviewed & tested by the community

Perfect, thank you! I think this is as ready as we can get it until the D7 version of Drupal.org is ready for feedback.

eliza411’s picture

eliza411 commented
Status: Reviewed & tested by the community » Closed (fixed)
eliza411’s picture

eliza411 commented
Issue summary: View changes

.