Download & Extend
Ubercart » Issues

Attributes form query converted to dynamic query for altering.

Posted by betz on October 31, 2012 at 11:09pm
Project:Ubercart
Version:7.x-3.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hi,

Ì converted the query that gets all the combinations for the adjustments form to a dynamic query.
This way i can alter the query from a contrib module i just created on http://drupal.org/project/uc_attribute_ignore

This patch just does exactly the same as the original query, i just added a tag to it.
Could this be committed?

Cheers!
-- Tom

AttachmentSizeStatusTest resultOperations
ubercart-attribute-query.patch1.83 KBIdlePASSED: [[SimpleTest]]: [MySQL] 2,459 pass(es).View details
Login or register to post comments

Comments

#1

Posted by betz on October 31, 2012 at 11:10pm
Status:active» needs review

#2

Posted by longwave on November 16, 2012 at 2:59pm

I fixed the coding standard issues in the patch, but otherwise this is unchanged. We have a test for the adjustments form, so if this passes and you confirm it's okay, then I will commit it.

AttachmentSizeStatusTest resultOperations
1828596-attribute-adjustments-dynamic-query.patch1.83 KBIdleFAILED: [[SimpleTest]]: [MySQL] 2,676 pass(es), 8 fail(s), and 0 exception(s).View details

#3

Posted by System Message on November 16, 2012 at 3:16pm
Status:needs review» needs work

The last submitted patch, 1828596-attribute-adjustments-dynamic-query.patch, failed testing.

#4

Posted by longwave on November 16, 2012 at 3:30pm
Status:needs work» needs review

Heh, well at least the tests work.

AttachmentSizeStatusTest resultOperations
1828596-attribute-adjustments-dynamic-query-4.patch1.86 KBIdlePASSED: [[SimpleTest]]: [MySQL] 2,685 pass(es).View details

#5

Posted by betz on November 16, 2012 at 3:31pm
Status:needs review» needs work

Yes, I could't get this query to work in this way also.
So I guess it is more then just coding standards, it changes the query all together...

#6

Posted by longwave on November 16, 2012 at 3:51pm

leftJoin() is not chainable, as it returns an alias. #4 seems to work, though.

Chainable vs non-chainable methods: http://drupal.org/node/1060924

#7

Posted by longwave on November 16, 2012 at 3:51pm
Status:needs work» needs review

#8

Posted by betz on November 16, 2012 at 4:31pm
Status:needs review» reviewed & tested by the community

Just applied patch to dev and tested, everything seems to work normally.

#9

Posted by longwave on November 16, 2012 at 6:23pm
Status:reviewed & tested by the community» fixed

Committed.

#10

Posted by System Message on November 30, 2012 at 6:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here