I'm not sure this is a Core issue or not, or even what component, so here's a short screencast of me demonstrating (with travel-weary voice)

http://screencast.com/t/hNlfmRX2H8

In short, if you click "Hide this message" link on the dsm() that prods you to install Advanced Help doesn't actually hide the message.. it directs the browser to the Settings tab, and when you go back to the List tab, the dsm() is still there

CommentFileSizeAuthor
#9 1828776-advanced_help_warning_text-9.patch1.64 KBslv_

Comments

Anonymous’s picture

Project: Drupal core » Devel
Version: 7.x-dev » 7.x-1.x-dev
Component: help.module » devel

Reassign to correct project.

salvis’s picture

@earnie: What makes you think this is Devel?

Anonymous’s picture

salvis’s picture

dsm() essentially just calls drupal_set_message().

The feature to display a "Hide this message" link and to act on it (or fail to act on it) is completely unrelated to dsm() or Devel. That is implemented in some other module. Devel is just the messenger.

@lisarex: You write that the link takes you to Settings, but it probably points somewhere inside Settings. What target does your browser display when you hover over the link?

lisarex’s picture

A-ha! It points to /admin/structure/views/settings. So it's a bug with the link.

salvis’s picture

This points to Views as the most likely culprit. What's your version of Views?

Can you search through your source code for admin/structure/views/settings — if you find that, then you'll know for sure...

slv_’s picture

Project: Devel » Views (for Drupal 7)
Version: 7.x-1.x-dev » 7.x-3.x-dev
Component: devel » User interface
Assigned: Unassigned » slv_
Category: bug » task

I think there's no real culprit for this at all. @lisarex, The 'hide this message' button does what it is intended to do (admittedly not what people would usually expect though).

If you see the settings tab on your screencast, it's got a checkbox with "Show advanced help warning" checked, which comes enabled by default . Disabling that and saving makes the message disappear.

So, everything is working as it should, but that message would indeed benefit from some better wording. I'll be happy to roll a patch for it, given the text doesn't make it obvious what the link is for.

Changing to views module and assigning to myself.

lisarex’s picture

@salvis, I just went to the module listing page and it's Views 7.x-3.5.

@slv_ thanks

slv_’s picture

Status: Active » Needs review
StatusFileSize
new1.64 KB

Patch attached.

dawehner’s picture

Link to another discussion around that topic: I think making a better text here is the solution to go, it should not automatically hide.

slv_’s picture

I agree with you on that, but not sure what you mean by "Link to another discussion". Did you want to paste a link to somewhere else, or is there another issue covering this issue?.

Otherwise, patch on #9 replaces the test to something I'd find more appropriate.

Cheers

dawehner’s picture

dawehner’s picture

Status: Needs review » Fixed

Perfect, let's get it in now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.