Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
1 Nov 2012 at 06:58 UTC
Updated:
29 Dec 2012 at 14:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Anonymous (not verified) commentedReassign to correct project.
Comment #2
salvis@earnie: What makes you think this is Devel?
Comment #3
Anonymous (not verified) commentedhttp://api.drupal.org/api/devel/devel.module/function/dsm/7
Comment #4
salvisdsm() essentially just calls drupal_set_message().
The feature to display a "Hide this message" link and to act on it (or fail to act on it) is completely unrelated to dsm() or Devel. That is implemented in some other module. Devel is just the messenger.
@lisarex: You write that the link takes you to Settings, but it probably points somewhere inside Settings. What target does your browser display when you hover over the link?
Comment #5
lisarex commentedA-ha! It points to /admin/structure/views/settings. So it's a bug with the link.
Comment #6
salvisThis points to Views as the most likely culprit. What's your version of Views?
Can you search through your source code for
admin/structure/views/settings— if you find that, then you'll know for sure...Comment #7
slv_ commentedI think there's no real culprit for this at all. @lisarex, The 'hide this message' button does what it is intended to do (admittedly not what people would usually expect though).
If you see the settings tab on your screencast, it's got a checkbox with "Show advanced help warning" checked, which comes enabled by default . Disabling that and saving makes the message disappear.
So, everything is working as it should, but that message would indeed benefit from some better wording. I'll be happy to roll a patch for it, given the text doesn't make it obvious what the link is for.
Changing to views module and assigning to myself.
Comment #8
lisarex commented@salvis, I just went to the module listing page and it's Views 7.x-3.5.
@slv_ thanks
Comment #9
slv_ commentedPatch attached.
Comment #10
dawehnerLink to another discussion around that topic: I think making a better text here is the solution to go, it should not automatically hide.
Comment #11
slv_ commentedI agree with you on that, but not sure what you mean by "Link to another discussion". Did you want to paste a link to somewhere else, or is there another issue covering this issue?.
Otherwise, patch on #9 replaces the test to something I'd find more appropriate.
Cheers
Comment #12
dawehnerFailed to link it: #857282: Advanced help message
Comment #13
dawehnerPerfect, let's get it in now.