Update entity class names after the conversion to plugins

updated_entity_classes.patch queued for re-testing.

+++ b/core/lib/Drupal/Core/Entity/Entity.phpundefined
@@ -251,7 +251,7 @@ public function getIterator() {
-  public function access(\Drupal\user\User $account = NULL) {
+  public function access(\Drupal\user\Plugin\Core\Entity\User $account = NULL) {

+++ b/core/lib/Drupal/Core/Entity/Field/Type/EntityTranslation.phpundefined
@@ -233,7 +233,7 @@ public function isEmpty() {
-  public function access(\Drupal\user\User $account = NULL) {
+  public function access(\Drupal\user\Plugin\Core\Entity\User $account = NULL) {

+++ b/core/lib/Drupal/Core/TypedData/AccessibleInterface.phpundefined
@@ -15,12 +15,12 @@
-  public function access(\Drupal\user\User $account = NULL);
+  public function access(\Drupal\user\Plugin\Core\Entity\User $account = NULL);

None of these should be inline like that, they should all have use statements.

The rest is all docs, but those 3 above are worrying. A sign of no test coverage?

Checked with git diff --color-words, looks good.

I've re-opened the other patch for more discussion, postponing this one.

Actually this actually just makes the status quo consistent. I don't see a reason not to commit this, even if we end up changing the implementation. I fear that when we decide to roll that one back, that it won't be able to revert cleanly anyway, and this will make it easier to grep for "Plugin/Core/Entity". Moving back to RTBC. I don't feel strongly here, though, so in case someone marks it back I won't mind.

OK no I actually think this is weird. We're not using real plugins for entities, just annotation discovery, so having the class name in the Plugin namespace is confusing.

I've opened #1847002: Move entity type classes from Drupal\$provider\Plugin\Core\Entity to Drupal\$provider\Entity as the issue to deal with that.

5: 1828852-update_entity_classes-5.patch queued for re-testing.

Is this still relevant? I am hard-pressed to find even one instance of the issue described above in the latest HEAD. I guess it got sorted out with everything else? I am marking this as Closed (cannot reproduce) for now. Please reopen if you find this is incorrect.