hello aron

a feature request (or i missed something):

if i create a new "NodeFeedItem" i get no option: "Delete news items older than:". This is fine, because the normal user should not define it.

In the "Edit" mode of this node i get the option.

Maybe a default value in the administration would be nice - otherwise my database will burst sometime in the future :), because i forget to edit the new nodes.

thanks and greetings
momper

CommentFileSizeAuthor
#1 per_node_type_presets_for_feedapi_settings.patch13.02 KBalex_b

Comments

alex_b’s picture

alex_b commented
Title: "Delete news items older than:" no default » Per node type presets for general feedapi settings
Status: Active » Needs review
StatusFileSize
new per_node_type_presets_for_feedapi_settings.patch13.02 KB

Exactly. This one was missing. This patch should implement per content type presets for general feedapi settings. It feeds feedapi specific settings through the settings handler of feedapi.module. I. e. : feedapi.module implements its own hook_feedapi_settings_form() hook.

alex_b’s picture

alex_b commented
Status: Needs review » Fixed

Aron tested this patch - thank you aron. Committed: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/feedapi/fee...

alex_b’s picture

alex_b commented
Status: Fixed » Active

I reopen this issue. There are 2 places, where "delete items after..." and "update existing items" are being stored: the settings field on one hand and the items_delete and update_existing field on the other hand.

We should consolidate this:

# We should only keep settings as a db field, if we want to select fields by its value.

So, we won't select feeds by update_existing - but how about items_delete? Do we need to select feeds by items_delete value?

Alex

alex_b’s picture

alex_b commented

BTW, part of the reason why "update_existing" and "items_delete" are not working properly at the moment is because they are not being stored on 'insert' - compare 'insert' and 'update' in feedapi_nodeapi().

alex_b’s picture

alex_b commented
Component: Code » Code (general)
Status: Active » Closed (fixed)

Closing after 18 months of inactivity.