I think the appropriate approach for this is the pathologic module.

CommentFileSizeAuthor
#14 implement_pathologic-1829548-14.patch3.05 KBmglaman
#13 implement_pathologic-1829548-13.patch2.17 KBmglaman
#12 implement_pathologic-1829548-12.patch2.41 KBmglaman
#11 implement_pathologic-1829548-11.patch2.01 KBmglaman
#6 1829548-panopoly-wysiwyg-use-pathologic-6.patch1.74 KBjoelcollinsdc
#5 1829548-panopoly-wysiwyg-use-pathologic-5.patch1.39 KBccarnnia
#1 panopoly-use-pathologic-1829548-1.patch1.49 KBjoelcollinsdc

Comments

joelcollinsdc’s picture

joelcollinsdc commented
StatusFileSize
new panopoly-use-pathologic-1829548-1.patch1.49 KB

attempted patch attached

populist’s picture

populist commented
Title: Convert linkit urls to url aliases in wysiwyg » Better Handling of LinkIt Links

There are a few problems we might run into with Linkit module..

1.) URLs are not properly aliased which the patch in #1 addresses

2.) Trouble with language support which #1793896: LinkitSearchPluginEntity needs createPath with language support addresses

populist’s picture

populist commented
Status: Active » Postponed

Postposing till a future release

populist’s picture

populist commented
Title: Better Handling of LinkIt Links » Implement Pathologic Module
Status: Postponed » Active

I think we might need the Pathologic module

ccarnnia’s picture

ccarnnia commented
StatusFileSize
new 1829548-panopoly-wysiwyg-use-pathologic-5.patch1.39 KB

rerolled the patch

joelcollinsdc’s picture

joelcollinsdc commented
StatusFileSize
new 1829548-panopoly-wysiwyg-use-pathologic-6.patch1.74 KB

applying to both filters

populist’s picture

populist commented

I am going to postpone since #1965864: Support CKEditor in Panopoly might shake this up.

populist’s picture

populist commented
Status: Active » Postponed
PedroKTFC’s picture

PedroKTFC commented

I'm trying panopoly. I use pathologic elsewhere and find it essential for sorting out image paths in dev/test/prod type uses. I've installed it but it doesn't seem to be working. Reading this thread I'm confused (not hard!). Am I right in thinking it shouldn't work with the standard distribution? Do I need the patch described here to get it to work with panopoly?

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

This patch adds the Pathologic filter to be used by the WYSIWYG text formats. You can also do that on your Drupal site and store the overrides in a module! So, this patch isn't strictly necessary to use Pathologic - it's to add Pathologic support by default, which probably is a good idea. I also use Pathologic on many of my sites. :-)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
Status: Postponed » Needs review
StatusFileSize
new implement_pathologic-1829548-11.patch2.01 KB

Here is a patch to implement Pathologic. Using Features Overrides isn't working all that great. For some reason the override for pathologic gets removed from the WYSIWYG text filter (but not HTML) whenever recreated.

Patch is from my duplicate #2290597: Add Pathologic for better LinkIt URLs

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new implement_pathologic-1829548-12.patch2.41 KB

Re-roll of patch. Realized there was no install file to provide update hook which enables the Pathologic module! We also ran into a lot of URL issues by having the options set to "Full", patch now puts Pathologic at "Path" (relative) setting. This prevents issues where you have SSL/non-SSL or migrate domains.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new implement_pathologic-1829548-13.patch2.17 KB

Re-roll against latest dev.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new implement_pathologic-1829548-14.patch3.05 KB

Rollin' rollin' rollin' to latest.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: +sprint
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Issue tags: -sprint +Needs tests

Actually, I think I added this to the sprint on accident :-)

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Would this patch technically become postponed due to 1.x roadmap to maintenance and bug fixes? Wonder, because I'd like to write the tests for this, but don't want to if it's a no-go :)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Postponed

Given that we already have so much other stuff to finish for Panopoly 1.x, I'm going to say "no" on this one and mark as Postponed.