Achievement as entity

Setting priority to normal, according to http://drupal.org/node/539608

This sounds like a feature that should live in the existing achievements project as 2.x branch. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the achievements issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

@klausi: this stuff wouldn't ever make it into the core Achievements branch (that module is fundamentally opposed to allow UI-based creation of achievements, as described on its project page), and this code also includes a lot more stuff that isn't part of the core Achievements package (such as Mozilla backpack integration, something which also already exists in http://drupal.org/project/amobb).

I think the code in the current sandbox is not meant to all go into one Drupal project, right?

I can easily see these things being split out into their own projects though - "Achievements as Entity", for example, would be a good one (though, I've not looked at the code fully yet, so I'm not sure how points are being handled), "Achievement User Permissions" would be another one (a module that allows users to decide the privacy of their own badge), etc. I'd be happy to link to them from the Achievements project page.

As it stands, though, I don't think the sandbox, in its entirety, should be a single Drupal project - there's just
too much "stuff" in there, and it almost sounds like an install profile, not pick-and-choosable extension modules.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

hi ,
1 ) your sandbox link is invalid and you should copy your git clone link here
2 ) README.txt is missing
3 ) Remove all old CVS $Id tags, they are not needed anymore.
like this :
achievement_entity/modules/achievement_notifications/achievement_notifications.module:3:// $Id: achievement_notifications.module 108 2012-09-05 05:17:57Z vaibhav $
4 ) you have many errors and warning in your code use this website http://ventral.org/pareview/
for finding and fixing your errors

Project page link

Back to "needs work" since there are several tasks to do:

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Major coding standards / best practice issues

An automated review of your project has found some issues with your code; As coding standards make sure projects are coded in a consistent style we please you to have a look at the report and try to fix them. Anyway, note that issues found are possibly false positives and fixing all issues is not a requirement for getting through the application process.

You can find the results of the automated report at http://ventral.org/pareview/httpgitdrupalorgsandboxebizondrupalservices1....

Consider moving the contents of "achievement_entity" to the main directory. Otherwise it could be very confusing after downloading this module.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

update sandbox url