I have a PDF file in which one of the field keys is "Date - mm/dd/yyyy". When I try to access the Edit field mapping page, which is at "admin/structure/fillpdf/147/edit/Date - mm/dd/yyyy", I get a "page not found" error. The URLs need to use an encoded version of the field key to avoid having incompatible characters.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | fillpdf_edit_slash_1830168_8_d6.patch | 1.23 KB | alexborsody |
| #8 | fillpdf_edit_slash_1830168_8.patch | 1.08 KB | wizonesolutions |
| #5 | fillpdf_edit_slash_1830168_5.patch | 1.05 KB | wizonesolutions |
| #3 | fillpdf_edit_slash_1830168.patch | 1.06 KB | liam morland |
Comments
Comment #1
wizonesolutionsThanks for reporting. If you've got time to post a patch I can commit it.
Comment #2
liam morlandThe attached patch fixes the problem by using an encoded version of the pdf_key in the URL. It makes the URLs a bit messy since they have to be run through rawurlencode() twice. It would be tidier and work to, for example, replace "/" with "!", but then you couldn't have an exclamation mark in a pdf_key.
Comment #3
liam morlandComment #4
wizonesolutionsEdit link for a field called Personal/FirstName doesn't work. Only single encoding seems to be needed. Troubleshooting patch.
Comment #5
wizonesolutionsLet me know if this one still works for you. I'd commit it, but I assume you did not double-
rawurlencodewithout a good reason. Let me know more about your use case, browser, anything that might be affecting things.Comment #6
liam morlandSometimes, %2f gets decoded and sometimes it doesn't. It depends on the setting of Apache's AllowEncodedSlashes Directive. Encoding it twice will always work.
Comment #7
wizonesolutionsI think you didn't double-decode then, so it failed on my system. I got a page not found. Will take another look.
Comment #8
wizonesolutionsDouble decode works. Patch attached. Does this look good to you? If so, will commit.
Comment #9
liam morlandAh, with my Apache setting, I didn't need to double decode because Apache was already doing that. I will test your latest patch Monday and get back to you.
Comment #10
liam morland#8 works for me.
Comment #11
wizonesolutionsPushed (06cd92a).
Comment #12
wizonesolutionsOh yeah. D6.
Comment #13
liam morlandComment #14
x-drup commentedComment #15
x-drup commentedComment #16
alexborsody commentedThanks, D6 patch attached.
Comment #17
alexborsody commentedCommitted in acb41b5.
Comment #18
alexborsody commentedthis is the correct patch
Comment #19
dmgenesys commentedIn my case this patch killed the ability to edit mappings resulting in 404 for fields that did not contain slashes - removing the patch restored editing. Please take a look.
Comment #20
wizonesolutionsPlease open a new issue so we can work on this against a known version. Test it on the latest 6.x or 7.x -dev version. This issue is already done with.