Closed (duplicate)
Project:
Lost & found issues
Component:
Twig templates conversion (front-end branch)
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Nov 2012 at 15:47 UTC
Updated:
9 Mar 2013 at 15:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
steveoliver commentedWe don't need this, as we already look for template files by theme hook name (after replacing underscores with dashes).
Make this read "Preprocess variables for locale date format form templates."
Remove all these lines.
Comment #2
artofeclipse commentedapplied all changes.
Comment #3
artofeclipse commentedComment #4
steveoliver commentedworking on getting '/admin/config' fixed before I can review.
Comment #5
artofeclipse commentedComment #6
steveoliver commentedNeeds some cleanup in the template docblock. I will finish this up.
Comment #7
joelpittetAlso have a go at the theme() function so it doesn't throw errors due to the new stuff it's getting from the preprocessor. (Hint you won't see errors in bartik because of #1855520: System status messages missing from Bartik)
Comment #8
steveoliver commentedWhat's a path for viewing this theme output?
It seems it should be something like admin/config/regional/date-time/formats/long/edit, but it's not (apparently).
Comment #9
artofeclipse commented@steveoliver you can find it by visiting admin/config/regional/date-time/locale but before that you have to enable local module.
Comment #10
steveoliver commentedThanks, artofeclipse. I'll be able to check it out later today.
Comment #11
steveoliver commentedsorting doesn't work.
Comment #12
mordonez commented@steveoliver the
system_date_format_localize_formfunction only affects the edit locale form format. For example:admin/config/regional/date-time/locale/en/edit(see the attach)This table is not sortable.
Comment #13
steveoliver commentedOK, Cool. Let's roll this into #1898454: system.module - Convert PHPTemplate templates to Twig. Could you please post this patch to that issue?