• FileField now works with file_revisions.
  • Filenames can now be renamed on the fly using regular expressions.
  • The URL: in the Description column of the file list form now works
    properly and matches the name the file will have after uploaing (token
    replacing, filename replacement and the _0, _1, _2,... thing are
    incorporated.
  • theme_filefield_icon works now a bit differently... A folder is scanned
    to look for allowed extensions + if no extension (or 'not found' image) is
    found, then the type will be returned as text. This is done in an extra
    column in the table.
CommentFileSizeAuthor
filefield.module_0.patch28.79 KBdavyvdb

Comments

jpetso’s picture

jpetso commented
Status: Needs review » Closed (fixed)

I know it's a bit of work, but in order to get this stuff into filefield (at least the revisions stuff sounds very exciting to me), could you please split your changes into separate patches instead of one big module file? The way it's done at the moment is barely useful from a maintainer point of view, except for getting inspired by the approaches you took - but it's harder than it should be to figure out what has changed, where it belongs and why it's necessary.

It would be very helpful if each of your improvements could be considered on its own merits in a separate issue, with a separate patch. Therefore, I close this patch and hope for four new issues.