I am using view_infinite_scroll to load new content. The images in the content loaded via AJAx are not being loaded. Is resp_img using a behavior to do the replacement with picturefill?

CommentFileSizeAuthor
#7 1830754-behavior-7.patch1.85 KBluksak
#5 1830754-behavior-5.patch1.86 KBluksak

Comments

luksak’s picture

luksak
he/him
commented

I solved the issue with this:

Drupal.behaviors.respImgAjax = {
  attach: function (context) {
    window.picturefill();
  }
};

Shouldn't, resp_img be doing this on it's own?

attiks’s picture

attiks commented

No resp_img uses a polyfill that only loads on window.load, but I like the solution

luksak’s picture

luksak
he/him
commented

Should I create a patch that implements this? We would have to stop picturefill to run on window.log then.

attiks’s picture

attiks commented

Patch is always welcomed

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
StatusFileSize
new 1830754-behavior-5.patch1.86 KB

There you go. I removed the event listeners from picturefill, except the resize event listener.

attiks’s picture

attiks commented
Status: Needs review » Needs work 
+++ picturefill/resp_img.jsundefined
@@ -0,0 +1,10 @@
+  ¶

trailing whitespace

+++ picturefill/resp_img.jsundefined
@@ -0,0 +1,10 @@
+      alert('test');

some test code

luksak’s picture

luksak
he/him
commented
StatusFileSize
new 1830754-behavior-7.patch1.85 KB

Fixing the code style

luksak’s picture

luksak
he/him
commented
Status: Needs work » Needs review
attiks’s picture

attiks commented
Status: Needs review » Fixed

I got this error while trying to apply the patch: "fatal: git diff header lacks filename information when removing 1 leading pathname components (line 45)"

So I did it by hand

Can you test it?

luksak’s picture

luksak
he/him
commented

I already switched to picture. If I have time, I will test it.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.