Convert omit_vary_cookie to cmi

Not sure if the TRUE in default.settings.php is correct or if it should be 1.

TRUE looks ok but we need an update function for cmi variables.

updated with that change.

+++ b/core/modules/system/system.installundefined
@@ -2305,6 +2305,18 @@ function system_update_8039() {
+}
+
+
+/**

Can we remove 1 newline here.

+++ b/sites/default/default.settings.phpundefined
@@ -444,7 +444,7 @@
-# $conf['omit_vary_cookie'] = TRUE;
+# $conf['system.performance']['cache.page.omit_vary_cookie'] = TRUE;
 
 /**
  * CSS/JS aggregated file gzip compression:

I'm prety sure it needs to be # $conf['system.performance']['cache']['page']['omit_vary_cookie'] = TRUE;

The first two elements are a key the last ones are array elements

Looking at some of the other variables in default.settings.php I think it works either way, unless they are wrong too.

re-roll

stupid error.

#11: 1831076-omit_vary_to_config-drupal8-11.patch queued for re-testing.

rerolled to update system number.

#14: 1831076-omit_vary_to_config-drupal8-14.patch queued for re-testing.

re-rolled again.

re-rolled again.

Did you test it? I did with the incorrect settings.php stuff currently in core:

#1873008: Settings.php conf overrides are incorrect

change made.

Great :)

Committed and pushed to 8.x. Thanks!