Remove the "More" area from the bottom of handler configuration

Screenshot of current behavior.

Here is a list of places what the more fieldset is used for:

• General: Administrative title
• Node edit link field: Checkbox to add the current view as destination after editing the node.
• Fieldapi field: Select field to choose on which internal value to clicksort.
• Has new content field: Checkbox to use new comments additional to new nodes.
• User link field: Advanced settings how to display the anonymous user
• Contextual filters: Allow multiple values and some more advanced edge case settings
• Contextual filters for numbers: Exclude the items instead of include
• Contextual filters for strings: Glossary options
• Filters: $Key used in the query, for example ?$key=Value

So ~80% of the time there's one, maybe 2 items in the More section. I still think it's disruptive more than useful.

The only place in which we currently multiple items are contextual filters. It seems to be that these settings are all pretty much advanced so putting
them in there might make sense. In the issue queue there have been quite some users which haven't been able to find out "how to configure a glossary" so we
might should move these options out into a new fieldset?

I personally would suggest to put in a total different fieldset, to make it clear what can be done there.

For now the admin label is still part of the more fieldset (not sure what to do with it), though if we expose the admin label more visible to the users
we might don't have to add [hidden] to the fields? (just an idea)

Moved some of the settings into a new fieldset

The last submitted patch, drupal-1831080-9.patch, failed testing.

#12: drupal-1831080-12.patch queued for re-testing.

#12: drupal-1831080-12.patch queued for re-testing.

I tried to test this on simplytest.me but it didn't behave as I expected, is this bugged or is it simplytest.me?

If we really want to move out the adminstrative label, then please let's fix #1838010: Remove redundant admin labeling on AreaPluginBase first.

Yup, @dawehner does this need a reroll?

To find out what the patch does, I did the following.
I installed drupal 8 without the patch, went to admin/structure/views and added a view
In the view, I went to Filter Criteria and chose "add"
I chose "Content: Author uid" and clicked Apply
The resulting window had "MORE" as a choice at the bottom; when I clicked on it, the only thing under it was "Administrative Title." This is illustrated in the following screenshot:

I then went back to the view window and selected ADVANCED
I went to Contextual Filters and clicked "add"
I chose "Content: body" and clicked Apply
The resulting window had "MORE" at the bottom. When I clicked MORE, "Administrative Title" came up, and so did several other items. These are illustrated in the following screenshot:

I then applied the patch and reinstalled drupal 8.
I repeated the steps to apply the filter criterion "Content: Author uid"
The resulting window still had "MORE" as a choice at the bottom, and when I clicked on it, the only thing under it was still "Administrative Title." This is illustrated in the following screenshot:

I then repeated the steps to apply the Contextual Filter "Content: body"
The resulting window still had "MORE" as a choice at the bottom. When I clicked on it, the only thing under it was "Administrative Title." The additional items that had been there before the patch was applied were no longer there.

I then went back and saw that a dropdown choice called "STRING SETTINGS" was present. When I clicked on it, the items that had been present under "MORE" before the patch was applied were displayed. This is illustrated in the following screenshot:

So as far as I can tell what the patch did was to remove everything except for "Administrative Title" from "MORE" and put them under a more informative heading, but the issue of having the "MORE" dropdown choice with nothing under it except for "Administrative Title" is still present with the patch.

Thanks @bannockree that write up is excellent. It says what you did in a way that someone else can repeat the steps later if they need to. And those embedded screenshots very well illustrate what is happening before and after the patch.

I took off the needs screenshot tag. We can add it back later if this needs more screenshots.

If the only thing now in that fieldset is going to be admin title, then @Bojhan's suggestion in #24 sounds like enough to get this in.

I'll update the issue summary with the next step.

@lisarex Nope, the fieldset should be "Administrative title". There is nothing alternative, it is the title we use for administrative purposes. It is also the convention to label it like this.

We do not want to remove the fieldset, its often not relevant - having it in a collapsed fieldset for that purpose is fine.

Having a single element hidden in a fieldset is pointless IMO. Bad UX and waste of space if you ask me.

...don't know why that tag was removed. Sorry :/

As for my comment, I was speaking in general - it was not meant for this specific use case only. Fieldsets AFAIK are used to group things together. That is their main function. There's no point in grouping a single item by itself. The ability that fieldsets have to be collapsed can be used to hide distracting/confusing things away, but that is a secondary function IMO.

If we want to reduce importance we could simply have a label read "Optional administrative title" or "Administrative title (optional)"

The last submitted patch, drupal-1831080-32.patch, failed testing.

Yep, I see that. I was just brainstorming over this. I'm currently taking a look at all the places this issue effects (these mentioned in #3). I'll post here if I come up with something useful/worthwhile.

I think most of them are moved under a specialised fieldset called "Filter identifier"