Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
statistics.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
4 Nov 2012 at 15:35 UTC
Updated:
29 Jul 2014 at 21:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexpottTagging
Comment #2
miro_dietikerFirst try.
Comment #3
miro_dietikerComment #4
aspilicious commentedCan you explain to me what the variable does. I wonder why you reoved the cron part.
Comment #6
miro_dietikerRename was required anyway.
The variable has nothing to do with cron (no related match).
Also added uninstall for state.
Comment #7
miro_dietikerRenamed to fully qualified name, as the other similar issue #1831486: Convert comment variables to config/state
Comment #9
pdrake commentedThis adds another statistics variable to the conversion and hopefully fixes the test.
Comment #10
miro_dietikerLooks great! Thanks! :-)
Comment #11
berdirLooks good. All those test additionals are going to conflict in ugly way, but it doesn't really matter in which order they get in, most will probably require some re-rolls.
Comment #12
catch#9: drupal-convert_statistics_variables_with_tests_and_uninstall-1831522-9.patch queued for re-testing.
Comment #14
pdrake commentedFixed merge conflict.
Comment #15
berdirRe-roll.
Comment #17
berdir#14 Looks fine, the only difference to #15 is that we inserted the conflicted bit at a different location. Tstbot needs to confirm of course.
Comment #18
catchCommitted/pushed to 8.x, thanks for the quick re-roll.