I clicked through the previous revisions and saw no diffs. After some URL comparison I saw there is a difference, but I have not digged deaper into the code.

Current revision: en/node/4/revisions/view/693/924/1963
Standard: en/node/4/revisions/view/693/924
Mark down: en/node/4/revisions/view/693/924/raw-plain

Click on the Standard or Mark down will show the diffs. I think this is wrong.

Comments

hass’s picture

hass commented
Title: Previous revision does not show diffs » Previous/Next revision does not show diffs

Hm... once I clicked Standard the next/previous links are working.

Note: I'm using Workbench Suite.

alan d.’s picture

alan d. commented

How did you get the first URL? This appears invalid as the format is:

"node/[nid]/revisions/view/[left vid]/[right vid]/[optional mark-down flag]"

hass’s picture

hass commented

Repro steps:

Go to node/4/moderation/diff (Workbench Diff tab)
Latest two versions radio'd (default selection), don't change anything
Press Compare button
node/4/moderation/diff/view/1963/2209 get's loaded
Mouse over < Previous difference has the link node/4/revisions/view/924/1963/1963

Looks more like a diff issue than a workbench issue to me as workbench integrates with diff here.

hass’s picture

hass commented

Must be $nav_suffix...

  // Generate previous diff/next diff links.
  $nav_suffix = ($default_state != $state) ? '/' . str_replace('_', '-', $state) : '';
  $next_vid = _diff_get_next_vid($node_revisions, $new_vid);
  if ($next_vid) {
    $next_link = l(t('Next difference >'), 'node/' . $node->nid . '/revisions/view/' . $new_vid . '/' . $next_vid . $nav_suffix, array('absolute' => 1));
  }
  else {
    $next_link = '';
  }
  $prev_vid = _diff_get_previous_vid($node_revisions, $old_vid);
  if ($prev_vid) {
    $prev_link = l(t('< Previous difference'), 'node/' . $node->nid . '/revisions/view/' . $prev_vid . '/' . $old_vid . $nav_suffix, array('absolute' => 1));
alan d.’s picture

alan d. commented
Status: Active » Fixed

Looks like a simple typo fix will resolve this, mostly.

However the integration is very poor, opened #1833950: Better Workbench Moderation integration to provide better third party module support.

hass’s picture

hass commented

Ah, you mean http://drupalcode.org/project/diff.git/commit/482840e with the typo.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.