Comments

nod_’s picture

Status: Active » Needs review
StatusFileSize
new1.64 KB

Very basic patch to get the 3 columns of views ui under each other on small screens.

nod_’s picture

Issue tags: +mobile

tag

Bojhan’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Usability, +VDC

Tested on my *cough* mobile computer by re-sizing the screen.

However it worked just fine, so marking RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Needs review

Let's get one of the VDC people to eyeball this/give it the OK.

dawehner’s picture

What about posting some screenshots, of before and after. I would like to post a review, but
some members of the VDC team has a clear backend oriented background.

damiankloip’s picture

I have to agree with Daniel, we are pretty much backend folks.

As long as my views UI is the same on my computer, I'm happy with this patch. I TRUST you guys in other words... :)

webchick’s picture

Issue tags: +Needs screenshots

Let's get a before/after screenshot.

yoroy’s picture

Status: Needs review » Needs work
StatusFileSize
new104.94 KB
new139.87 KB
new95.41 KB
new114.75 KB

Before:

 views ui 3 col layout, screenshot before

The 3 column layout becomes unusable at small screen widths

After:

screenshot after patch, 3 cols shown below eachother

The patch makes the 3 columns show below eachother at screen widths below 450px.

One problem and a question:

screenshot showing why and how of horizontal scrollbar

Is 450px the right breakpoint? I wouldn't mind this happening at around 600px or so, it really starts to get cramped from there.

- The text field for adding arguments in the preview section is too wide for really small screen widths, forcing a horizontal scroll bar:

Needs work for the unresponsive textfield right?

yoroy’s picture

StatusFileSize
new26.25 KB

The screenshot showing how the horizontal scrollbar is caused:

dead_arm’s picture

Status: Needs work » Needs review
Issue tags: -Needs screenshots
StatusFileSize
new61.48 KB
new99.77 KB
new18.12 KB
new72.04 KB
new2.22 KB

I agree that the breakpoint should be higher than 450px, as the column widths at 450px are really tight and the resulting wrapping makes it hard to use. I think 600px is more reasonable. The Advanced column when open is cramped even at 600px, but any wider than 600px might be too wide.

Views edit page at 600px - 3 columns

views-edit-600px.png

Views edit page at 600px with Advanced options open

views-edit-600px-advopen.png

Views edit page at 599px - Switches to 1 column

views-edit-599px.png

The textfield description had a 'no wrap', which is why the width was forced. Without it, the date wraps to the next line and looks out of place. I added a media query for that style so that the description wraps for smaller widths and not on wider ones.

Textfield wrap fix

views-previews-field-wrap.png

Patch attached uses a 600px breakpoint, includes the textfield wrap fix, and I also removed the LTR inline comment that was copied into the RTL sheet.

dawehner’s picture

StatusFileSize
new152.79 KB
new107.07 KB

Wow this is way better to edit on the mobile device (browser chrome)!
The same experience with the built in browser of android 4.x

tim.plunkett’s picture

+++ b/core/modules/views/views_ui/css/views-admin-rtl.cssundefined
@@ -62,14 +62,16 @@
+@media screen and (min-width:37.5em) { /* 600px */

This will be the only 600px breakpoint in core, the other media queries used are

@media screen and (min-width:28.125em) { /* 450px */
and
@media screen and (min-width:45em) { /* 720px */

Now that I'm rereading the issue I see #8/#10 said that 450px was too small, is 720px too big?

Bojhan’s picture

We might just want to go consistently with the core defined one, it will be weird if some things are wrapped and others things aren't.

tim.plunkett’s picture

I checked with @dead_arm, she chose the 600px while overlay was off.
I would imagine that with overlay on, 720px would end up being more like 600px.
I wonder how the other media queries deal with overlay.

dead_arm’s picture

Screenshots:

Media query at 700px without overlay:

Media query at 700px with overlay:

dead_arm’s picture

StatusFileSize
new72.78 KB
new65.19 KB

Sorry #15 was at the wrong width.

Media query at 720px without overlay:

720-nooverlay.png

Media query at 720px with overlay:

720-overlay.png

dead_arm’s picture

StatusFileSize
new2.11 KB

I think the UI change still works well at 720px so patch with that change attached.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Great, I feel much better about this now that we're following core's lead.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

I can't believe it only takes 2.11 KB to do what it says in the issue title. :) NICELY done!

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.