Entity translation metadata should be stored only for translation enabled entities/bundles

i'm not shure if this bug is related, bug berdir told me so ;)

i get this error

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: 'theme.bartik.mobile' for column 'entity_id' at row 1: INSERT INTO {translation_entity} (entity_type, entity_id, langcode, source, translate) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4); Array ( [:db_insert_placeholder_0] => breakpoint [:db_insert_placeholder_1] => theme.bartik.mobile [:db_insert_placeholder_2] => und [:db_insert_placeholder_3] => b [:db_insert_placeholder_4] => 0 ) in translation_entity_entity_insert() (line 516 of /Applications/MAMP/htdocs/d8t/core/modules/translation_entity/translation_entity.module).

here's how to reproduce this error:
on a fresh install (standard or minimal).
enable entity - translation, and add a second language.
add a conent-type (in minimal) and a content for it.
now enable the Picture Field-type - boom.

a second enabling of the Picture Module then works without error, and the filed itself actually works.

Suppose we should have a different kind of storage for configurables (contact category, image style)

Edit The easiest fix for now is to check for config_prefix in entity to make sure we are dealing with configEntity also it makes sense to change entity_id to entity_uuid or just does not allow entity*hooks for none integer entity_id as temp workaround

I'm not sure how configuration entities will be translated but for the moment, this should fix this for the moment and unblock the vocalary to configuration issue.

Will require a follow-up to support configuration entities but first they actually have to support translations. Might be as easy as making entity_id a string. Not sure about using entity_uuid, because we agreed in another issue to not use it for references.

nice - patch solves the listed error.

This makes sense, and it's blocking #1552396: Convert vocabularies into configuration.

Looks good. Bumping to major, as this seems to block a range of other issues.

Didn't find this because the issue title didn't mention the error mentioned in #1, so I opened #1832932: translation_entity_entity_insert() assumes entity IDs are integers. Don't know if that should be a duplicate. It's a different fix, which is also valid, IMO. I guess that one can be demoted once this is in.

Hm. We should get some tests for this, I think.

Ok, extended both node tests (to check for the bundle specific setting) and the taxonomy term tests to verify that we're not adding wrong rows.

Tests look good. Only two code comments:

+++ b/core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.phpundefined
@@ -67,4 +67,23 @@ protected function getNewEntityValues($langcode) {
+   * Test that no metadata is stored for a disabled

... bundle.

+++ b/core/modules/node/lib/Drupal/node/Tests/NodeTranslationUITest.phpundefined
@@ -67,4 +67,23 @@ protected function getNewEntityValues($langcode) {
+    // Create a bundle does not have translation enabled.

bundle THAT does not have?

Thanks!

This should be better.

Looks all good to me.

That was a known fail that's been fixed since.

#12: translation-entity-check-support-1832000-12.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!