Contact Environment

Welcome,

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

PAReview says there is no documentation block at the head of your .module file. That is the only error listed. prettry good.
FILE: ...tes/all/modules/pareview_temp/test_candidate/contact_environment.module
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
2 | ERROR | Missing file doc comment
--------------------------------------------------------------------------------

Hii,

Firstly the git credential you provided is for admin and maintainer. So if I try to clone using your module it asks for your git password.

To fix this:
1) Visit your sandbox page and click on the version control tab.
2) Next check the non-maintainer checkbox and hit "Show".
3) Update the link with command that comes there.

As I could not clone into your repo I was unable to do a manual review.

But the automated review still shows some errors. I think a few function headers are missing.

Please fix it and update the git repo link to get reviews. And please do participate in Review Bonous Programme.

Thanks,
Aritra.

Hi qudsiya,

1) You have to add a file contact_environment.install and implement contact_environment_install() function to alter your db tables. More details and usage example: http://drupal.org/node/185596#comment-941821
2) You have to add contact to dependencies[] in contact_environment.info.

Hi qudsiya,

Please have a look at http://groups.drupal.org/node/195848. Your module need to have atleast 5 functions or 120 lines of code to get a review.

Thanks,
Udaksh

@udaksh: No? It just says that we will have to promote the module manually instead of giving the git vetted user role away. Reviews are always welcome.

Could you tell me which sentence on that page confused you so that I can improve that documentation?

Sorry,

I misunderstood the 2 points with *. It is clear now. Thanks Klausi.

Nifty little tool :) The only thing I would like to see is some sort of admin panel where I can select which variables to include in the e-mails.

I see klausi's comment above, IF he is agree with the line of code constraint in module code review I don't think any one else from the community will raise any concern.

Your module just attaching some content at the footer of email. Why don't you provide some admin interface to allow admin to choose/config format or variables of the content you are attaching here.

Please don't take it personal its just a friendly suggestion. I think it will add advantage to the functionality of your module as well it will increase line of code.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/1832562

Project 2: https://drupal.org/node/2024431

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

I'd just like to follow up on the PA robot's #17: since January the only outstanding issues on this application have been feature requests that don't seem like essential prerequisites to moving it to contrib. We've been running this module in production for over eight months and I believe this module should be moved to contrib, manually if necessary, as seems to be the case based on udaksh's #8 and klausi's #9, above.