Panopoly admin requires the date module but it isn't declared in the make file. It is declared in panopoly_widgets though, that's why it isn't breaking inside of the panopoly distribution. Adding it in both places seems wrong, so maybe we should include it in panopoly_core instead?

CommentFileSizeAuthor
#2 panopoly-core-field-modules-1832758-2.patch739 bytesfabsor
#2 panopoly-widgets-field-modules-1832758-2.patch748 bytesfabsor

Comments

populist’s picture

populist commented
Title: Panopoly admin requires date, but doesn't declare it in the make file » Move Field UI Modules to Panopoly Core

Good question. I think the issue is a bit more global since there are the following modules in the panopoly_widgets.make:

projects[date][version] = 2.6
projects[date][subdir] = contrib

projects[field_group][version] = 1.1
projects[field_group][subdir] = contrib

projects[entityreference][version] = 1.0-rc5
projects[entityreference][subdir] = contrib

None of these are "required" by the widgets and are mostly there for helping things along. Since these are pretty useful modules (and a lot of apps will depend on them), I think it might make sense to move all to Panopoly Core.

fabsor’s picture

fabsor commented
Status: Active » Needs review
StatusFileSize
new panopoly-widgets-field-modules-1832758-2.patch748 bytes
new panopoly-core-field-modules-1832758-2.patch739 bytes

Here's two patches, one for core and one for widgets, that makes the move.

populist’s picture

populist commented
Status: Needs review » Fixed

Quite appropriate. Reviewed + Committed to -dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.