Rename the 'Translation settings' field type on the Content Type Manage Fields screen, as it refers to language settings

Grabbing it. :)

The attached patch changes the label from "Translation Settings" to "Language Settings" in translation_entity.module.

Before (screenshot):
https://www.evernote.com/shard/s163/sh/e6e38eed-9f8c-43c4-a2aa-3f64b9d46...

After (screenshot):
https://www.evernote.com/shard/s163/sh/f348b799-0970-4532-a0c3-5e4a13c94...

The other instance of "Translation Settings," not affected by this patch, is in translation.module and does seem to be accurately named:

      // Add translation values and workflow options.
      $form['tnid'] = array('#type' => 'value', '#value' => $node->tnid);
      $form['translation'] = array(
        '#type' => 'details',
        '#title' => t('Translation settings'),
        '#access' => translation_user_can_translate_node($node),
        '#collapsible' => TRUE,
        '#collapsed' => !$node->translate,
        '#tree' => TRUE,
        '#weight' => 30,
      );

Updated issue summary.

Rephrased the issue title. I'm not actually certain that this issue needs to be fixed, but just in case, the patch is in #4.

For context, content creators see a "Language" dropdown on the node/edit page (screenshot: http://bit.ly/VVk2KD) and "Translation" (rightly) in the translation-related vertical tab (screenshot: http://bit.ly/WUlIjH).

Patch applies, reviewed and tested.

Sorry guys, but this is missing a bit of discussion: do we really wanto to perform this change? Which is the rationale behind it? Why a vertical tab that will appear only when translation is enabled and that will contain only translation-related stuff should be called "Language settings", which is a more generic term that elsewhere is used to indicate stuff usually handled by the Language module?

As per fureigh's comment in #5, there is already a language select on the node form. The purpose of this Translation extra field on the form seems to be to allow a user to mark other translations as outdated - ie. it provides a widget used as part of the translation process, rather than being used for selecting a language.

Therefore to me, calling this field Language settings would actually be more confusing.

On the manage field the label is "Translation" and can't be changed.

But on the add content screen, the label is "Language" and this is inconsistent.

It is not the field type that is confusing. Is is the inconsistency between the manage fields screen and the content screens that is confusing. The label should be "Language", the machine name should be language and the field type should be Language.

As a follow up to #11, the purpose of this field is to allow the position of the "Language" setting on the Add content form to be changed. I think you were "confused" by the label.

Hi everyone, at the DrupalCon Sydney Code Sprint and doing manual testing of the patch in #4 and it works fine. I'll let you carry on discussing it's worth though :)

@mitron The Language selection field is different to the translation settings field. See the attached screenshot. You only see the translation field when you create a translation of a node, or are editing a node which has translations.

@ jamesharv: Try to move that "translation" field up or down in the manage fields screen. You'll notice that it causes the Language field to change position in the Add Content screen.

I wont comment on the requirement, but the patch at least looks fine.

Considering its been technically reviewed, is there another status we can use?

Apparently, the reason the translation field is shown on the manage fields screen is so the "Language" field can be repositioned. There are no other options to change. To see the "Language" field in add content, you must select "Show language selector on create and edit pages" on the Content Language Settings screen.

There are many things terribly confusing about the translation system for a new user, but I'll try to keep this focused on this exact issue. However, I suspect that the general "WTFness" of the translation system to a novice could possibly be behind the existence of this issue.

This issue summary states that calling the translation-related field type 'Translation settings' could be confusing but does not explain why it could be confusing. At first, I looked at the field type and thought "What is confusing about this?" It was perfectly clear. Then I asked myself, "How could this be confusing?" and thought "Why is this field even on the Manage Fields screen?" It does not appear to affect anything. At the time, I had not selected "Show language selector on create and edit pages" so the Language field did not appear.

Later I learned that the Translation Settings field only appears on the Translation tab and not on the Content Create/Edit tabs. And its appearance on the Manage Fields screen allows changing its vertical position.

So this issue is not about the general confusions of the translation system but just the name of the field type and I believe that the field type is good and should not be changed. I concur with "wont fix."