$r not available to drupal_eval

Hi! Thanks for this — I will look it over and see if I understand it. I initially used plain eval in this function; I switched over to drupal_eval because it seemed safer, but I didn't realize that it would keep $r from being available.

Thanks,
Ricky

I just found this same issue.

After patching your module could be nicely combined with "gtspam" to obfuscate mails in just a single line.
Evaluate this: return(gtspam($r['@mail']));

If you don't know your field name, give a try to: return(var_export($r));

Obviously gtspam module need to be installed and enabled. :-)

Thanks you guys for the great module and the patch.

Thank you cwells for your patch.

There is a few things I dislike about your patch.

1. Breaks re-usability - The function drupal_eval() is there to be used and it is perfect for this task.
2. Copy and Paste - You copied and pasted some code so that breaks maintainability since anyone making change to drupal_eval would have to know to change this code too...
3. Allow write access to the $r array and read/write access to all variables in that function.

Here is a patch which is less code change, reuse the existing drupal_eval() and only allow access to the $r array.

Let me know what you think.

I just looked at the patches real quick. This is sure a blast from the past, but if roychri's patch also works, it's a much better solution.

Here is an updated patch for the version 6.x-1.0-beta1 version.

Anyone else want to review and mark as RTBC?

Thanks.