Download & Extend
Site User List » Issues

$r not available to drupal_eval

Posted by cwells on October 14, 2007 at 1:36pm
Project:Site User List
Version:6.x-1.0-beta1
Component:Code
Category:bug report
Priority:normal
Assigned:pooneil
Status:closed (fixed)

Issue Summary

When eval'ing a template, you say that $r holds the values, but since you generate a code string and pass it to drupal_eval, drupal_eval has no knowledge of $r and so it can't be eval'd. I did the output buffering and eval'ing inline so that you have access to the $r array. I'm not sure this is the best way to do this, but it works.

AttachmentSize
site_user_list.patch834 bytes
Login or register to post comments

Comments

#1

Posted by pukku on October 15, 2007 at 12:49pm

Hi! Thanks for this — I will look it over and see if I understand it. I initially used plain eval in this function; I switched over to drupal_eval because it seemed safer, but I didn't realize that it would keep $r from being available.

Thanks,
Ricky

#2

Posted by mbria on May 30, 2008 at 6:41pm

I just found this same issue.

After patching your module could be nicely combined with "gtspam" to obfuscate mails in just a single line.
Evaluate this: return(gtspam($r['@mail']));

If you don't know your field name, give a try to: return(var_export($r));

Obviously gtspam module need to be installed and enabled. :-)

Thanks you guys for the great module and the patch.

#3

Posted by roychri on June 25, 2009 at 5:24pm

Thank you cwells for your patch.

There is a few things I dislike about your patch.

  1. Breaks re-usability - The function drupal_eval() is there to be used and it is perfect for this task.
  2. Copy and Paste - You copied and pasted some code so that breaks maintainability since anyone making change to drupal_eval would have to know to change this code too...
  3. Allow write access to the $r array and read/write access to all variables in that function.

Here is a patch which is less code change, reuse the existing drupal_eval() and only allow access to the $r array.

Let me know what you think.

AttachmentSize
183379.patch 664 bytes

#4

Posted by cwells on June 29, 2009 at 8:41pm

I just looked at the patches real quick. This is sure a blast from the past, but if roychri's patch also works, it's a much better solution.

#5

Posted by roychri on August 20, 2009 at 4:48pm
Version:5.x-1.x-dev» 6.x-1.0-beta1

Here is an updated patch for the version 6.x-1.0-beta1 version.

Anyone else want to review and mark as RTBC?

Thanks.

AttachmentSize
183379.patch 878 bytes

#6

Posted by pooneil on June 30, 2010 at 2:57pm

Hi cwells,

I applied the patch provided by roychri. I gave it a quick test and accessing the '$r' array works. The change is committed and should show up in the next release.

Regards,
Anthony

#7

Posted by pooneil on June 30, 2010 at 2:57pm
Assigned to:Anonymous» pooneil
Status:needs review» fixed

#8

Posted by System Message on July 14, 2010 at 3:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here