Problem/motivation

Delete confirmation messages on original language comments do not inform people that they also lose translations of their comments:

Steps to Reproduce

  1. enable content translation under extend
  2. add a few languages
  3. enable translation for content (article) and comments (on the configuration language settings page)
  4. create an article
  5. comment on the article
  6. translate the comment
  7. Try to Delete the original language comment

Proposed solution

Display confirmation warning when original language comment is about to be deleted, that translations of the comment will also be deleted.

Notes

Issue created based on #1833112: Make translations consistant with other delete tab patterns, picture by @greg.1.anderson.

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

We already have such a functionality implemented in the base translation controller. Probably it's not being called to to the different workflow: IIRC it's triggered by pushing the delete button from the entity form.

Probably the correct way to implement this is defining a generic delete form controller and display the warning while showing the confirmation form. See also #1728804: Introduce (Content)EntityDeleteForm and children to handle entity deletions.

chrischinchilla’s picture

chrischinchilla commented
Issue summary: View changes

Added steps to reproduce.

yesct’s picture

yesct commented

@chrischinchilla thanks for starting the steps to reproduce.

I expanded it a bit. (more detail could still be added, like the url of the pages to configure stuff)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Component: translation_entity.module » content_translation.module
JayMN’s picture

JayMN commented
Title: Delete confirmation messages for entities should include warning for translations » Delete confirmation messages for comments in original language should include warning for translations
Issue tags: +comments

Changing title because comments need warning that deletion of the original language comment will also delete translations, but this is not a problem for entities, nor for deleting translations of the comment.
Will change the summary, as well.
Tests:
From Content language settings, tested content (article) and comments. Did not test custom block, menu link, taxonomy term or user. Does anyone think testing of these other types is needed?
Results of tests:
For article, user was warned that deleting the original would delete translations. Deletion of translation of article does not delete original or other translations, so no warning is needed.
Deletion of original language comment lacked warning that translations would be deleted, so warning is needed. Deletion of translation of comment does not delete other translations, nor the original, so no warning is needed in those cases.

JayMN’s picture

JayMN commented
Issue summary: View changes

Updated issue summary, expanded steps

JayMN’s picture

JayMN commented
Issue tags: -comments

Cannot edit translation of node (article or basic page).
While testing in #4, above, stumbled on an error. Clicking on the edit tab for a translation of an article resulted in Fatal error: Call to a member function bundle() on a non-object in \core\modules\node\node.module on line 136. Can anyone tell me if this is a duplicate of another issue, or if not, where the issue belongs? (I've looked without success)
Steps to duplicate (tested on my local system and simplytest.me 8.x):

  1. Enable content translation under extend
  2. Add a few languages
  3. Enable translation for article and basic (on content language settings page)
  4. Create Article or Basic page
  5. Can create new revision or not
  6. Give article or basic page a title and body text
  7. Add a translation to article or basic page, change body text.
  8. Save and keep published.
  9. We are looking at the translated version of the article or basic page
  10. Click on Edit
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@JayMN: that issue is being handled in #1831846: Help block is broken with language path prefixes, I copied your steps to reproduce to #1831846-33: Help block is broken with language path prefixes and elevated that issue to Critical given that what was a notice before now makes editing impossible. It is not related to this issue here.

yesct’s picture

yesct commented
Issue tags: +Needs tests

we should be able to write a test for editing a translation. [edit: or maybe the tests should be added in the other issue.]

yesct’s picture

yesct commented
Issue summary: View changes

Updated issue summary.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there hasn't been a follow up going to close out, but don't worry we can always re-open!

Thanks all