Posted by Gábor Hojtsy on November 7, 2012 at 3:48am
3 followers
Jump to:
| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | translation_entity.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
| Issue tags: | D8MI, language-content, Usability |
Issue Summary
Problem/motivation
Delete confirmation messages on entities do not inform people that they also loose all their translations which are stored within their entity:
Steps to Reproduce
- enable content translation under extend
- add a few languages
- enable translation for content (article) and comments (on the configuration language settings page)
- create an article
- comment on the article
- translate the comment
- Try to Delete the translation of the comment (or delete the original comment)
Proposed solution
Make extra warnings present when there are translations of the entity. Might not be the responsibility of entity translation module per say.
Notes
Issue created based on #1833112: Make translations consistant with other delete tab patterns, picture by @greg.1.anderson.
Comments
#1
We already have such a functionality implemented in the base translation controller. Probably it's not being called to to the different workflow: IIRC it's triggered by pushing the delete button from the entity form.
Probably the correct way to implement this is defining a generic delete form controller and display the warning while showing the confirmation form. See also #1728804: Introduce EntityDeleteFormController and sons to handle entity deletions.
#2
@chrischinchilla thanks for starting the steps to reproduce.
I expanded it a bit. (more detail could still be added, like the url of the pages to configure stuff)