Nodewords Twitter

1) Don't forget to create a 7.x-1.x :
"Although master branches are commonly used in the Git world, the Drupal community uses major version branches (e.g., 7.x-1.x) instead, since master does not indicate what Drupal version the project is compatible to."

2) Please fix the coding style issues detected by automated tool: http://ventral.org/pareview/httpgitdrupalorgsandboxbuddhamagnet1823998git

3) Your project page has to be fullfilled : "Project pages should be helpful; there are literally thousands of modules, themes and installation profiles and site builders need a clear way to understand what a project does."

Please read this http://drupal.org/node/1011698 and this http://ventral.org/pachecklist before setting back the status to "needs review"

1. Basic application checks

1.1 Ensure your application contains a repository and project page link.
Ok

1.2 Ensure your project is not a duplication.

Ok

1.3 Ensure you don't have multiple applications.
Ok

2. Basic repository checks

2.1 Ensure the repository actually contains code.
ok

2.2 Ensure you are working in a version specific branch.

No remove master branch and create and version specific branch.

2.3 Ensure your project contains a minimum of handwritten code.
OK

3. Security Review

3.1 Ensure the project does not contain any security issues.
- Make sure you filter the input: Even from variable_gets or from your own functions.
- otherwise it looks an very nice project.

4. Licensing checks

4.1 Ensure the repository does not contain a ‘LICENSE.txt’ file.
ok
4.2 Ensure the repository does not contain any 3rd party (non-GPL) code.
ok
5. Documentation checks

5.1 Ensure the project page contains detailed information.

Project page needs some information. Readme is ok ==> if you add some sections it would be even better. REadme.txt can also be your project page homepage.

5.2 Ensure the repository contains a detailed README.txt.
ok, see above.

6. Coding standards and style

6.1 Run an automated review and ensure there are no major issues.
See comment above = NOT ok.

7. API and best practices Review
Yep - ok.

Manual Review:

1) Named your custom variable with module name like nodewords_twitter_max_size not like nodewords_max_size in line no: 164 in module file.

2) Also use variable_del() in hook_uninstall() to remove your variable nodewords_max_size.

3) Do not use t() or st() in installation phase hooks, use $t = get_t() to retrieve the appropriate localization function name.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

New module