I've found one spot where there is a fairly serious problem here, although it might've escaped notice for a while!

I'll just run through what happens.

Log in as uid 1
Go to blocks admin
(As an example) make "Powered by Drupal" block visible in content area
Configure this to be visible for only administrators
Go to front page
No block

Ah wait ok. I just figured it out. :) When you enable and configure the module, you add a role, right? But uid 1 user account is not in that role! Check the user edit page. Not sure how this module is overriding uid 1's priv to view all blocks etc but it doesn't work as it should.

I realise that simply adding the role to the user will work (I tested it) but shouldn't this work out of the box...? Kinda weird IMO.

Comments

niklp’s picture

niklp commented
Title: Permissions not allocated to uid 1 » Admin role not allocated to uid 1, causes abnormal behaviour
liquidcms’s picture

liquidcms commented
Component: Miscellaneous » Code
Assigned: Unassigned » liquidcms

yes, i can confirm this is a bug. very simple workaround though; simply add uid 1 to admin role. But i'll take a look and see if there is an east fix.

liquidcms’s picture

liquidcms commented
Status: Active » Closed (works as designed)

nope, not a bug in my module.. if anything its a bug in Drupal core but hard to tell as i suspect there are other places in core that do not strictly adhere to the premise that uid 1 has perms to everything.

to test; simply disable the adminrole module and i am sure you will still see that your block is still not visible by uid 1.

also, looking at my code it was obvious. all this module does is simply set the perms for everything for that role; it does nothing in real time such as manipulate access control.

i'll mark as closed for now but feel free to move issue to core.