For some reason Weight in JS isn't working when it comes to grouping, so we either need to find a way to fix this or find a workaround for it.

CommentFileSizeAuthor
#3 fix-weights-1834518-3.patch4.61 KBiamcarrico

Comments

Snugug’s picture

Snugug commented
Priority: Normal » Major
Snugug’s picture

Snugug commented
Status: Active » Closed (fixed)

This should be solved in 2.5 I hope

iamcarrico’s picture

iamcarrico commented
Status: Closed (fixed) » Needs review
StatusFileSize
new fix-weights-1834518-3.patch4.61 KB

Okay--- re-worked how this entire section worked.

I realized while we were chatting that we just need for order the scripts first, then do all the pretty grouping stuff to it. I think what was going on (and why I lost some inline scripts) is the sort put all non-preprocessed files together. Which will break local fall back scripts that were written.

I rather you look at it before I commit it... you know, so I don't make yah too angry.

This also ties in the issues fixes for #1818636: Notice: Undefined index: async in aurora_group_js() error with my new subtheme

Status: Needs review » Needs work

The last submitted patch, fix-weights-1834518-3.patch, failed testing.

iamcarrico’s picture

iamcarrico commented
Version: 7.x-2.4 » 7.x-2.5
Status: Needs work » Needs review
iamcarrico’s picture

iamcarrico commented

#3: fix-weights-1834518-3.patch queued for re-testing.

Put in the dev branch for now--- easiest place so we both can keep working on it.

iamcarrico’s picture

iamcarrico commented
Version: 7.x-2.5 » 7.x-2.6
Status: Needs review » Fixed

Pushed in 2.6

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.