Can you explain this commit?

3a71a86fcb5f79f43f1d519b4e4fc73ccf1bbd67

See this diff

Perhaps I'm not understanding the logic here, but I think this is causing issues on the multi-language site I'm working on where manually updating an alias is causing a redirect for all languages that share that url_alias dst. While this is an edge-case, it doesn't seem to make much sense.

If this behavior is desired, it should definitely be explained with a comment in the code.

Thanks!

CommentFileSizeAuthor
#1 un-comment-commented-code--1834790-1.patch809 bytesjessehs

Comments

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Active » Needs review
StatusFileSize
new un-comment-commented-code--1834790-1.patch809 bytes

I'm assuming this was a mistake introduced, but never caught, due to the edge-case nature of the problem that it causes. (It would only manifest when a translation has the same alias as its source node.)

Status: Needs review » Needs work

The last submitted patch, un-comment-commented-code--1834790-1.patch, failed testing.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Needs work » Needs review

#1: un-comment-commented-code--1834790-1.patch queued for re-testing.