My client wants a tag block that is not filtered by current node or taxonomy, so I created this patch.

CommentFileSizeAuthor
#6 tagadelic_show_all_tags-183501-6.patch3.24 KBAnonymous (not verified)
tagadelic.all_tags.patch.txt2.32 KBJacobSingh

Comments

Bèr Kessels’s picture

Status: Active » Needs work

I don't like the fact that it replaces the old block. Nor do I like code bing commented. This patch needs a lot of work before I can consider committing it.

JacobSingh’s picture

Hi Bèr,

Nice to know what you don't like. I needed to provide this for a client, if you have anything specific and constructive to say, I'd be happy to contribute. Let me know what you don't like or what is wrong with it, I'll fix it when I get time.

Best,
Jacob

Bèr Kessels’s picture

I thought I was clear about the specifics that I did not like. Let it be very clear that I think the feature itself is a very valuable one, if done properly :)

* You comment out the old code, instead of removing it. If I were to commit it, I don't want the patch to have commented-out-code.
* Instead of *adding* a new block, you replace the per-vocabulary blocks with your own. I prefer to keep the per-voc blocks and *add* a new one to the set of blocks.

Bèr

Bèr Kessels’s picture

Status: Needs work » Closed (won't fix)

No feedback or update for a long time. Closing old issues.

geek-merlin’s picture

subscribing

Anonymous’s picture

Title: Showing All Tags in Block » Ability to show all tags
Version: 5.x-1.x-dev » 7.x-1.x-dev
Assigned: JacobSingh » Unassigned
Status: Closed (won't fix) » Needs review
StatusFileSize
new3.24 KB

I'd also like this feature and so have attached a patch which provides this functionality to the latest 7.x-dev version.

It simply informs users that entering a '0' as the number of tags to show will result in all tags being displayed. This works for both blocks and pages.

It's working for me; hope others can test it out to confirm.

MGParisi’s picture

Nice Idea, I will try to implement it in my next patch, I am doing allot with this module!

Bèr Kessels’s picture

Status: Needs review » Closed (won't fix)

Please open a pull request on github if you still want this feature.