Closed (won't fix)
Project:
Tagadelic
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Oct 2007 at 03:01 UTC
Updated:
7 Feb 2012 at 14:31 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Bèr Kessels commentedI don't like the fact that it replaces the old block. Nor do I like code bing commented. This patch needs a lot of work before I can consider committing it.
Comment #2
JacobSingh commentedHi Bèr,
Nice to know what you don't like. I needed to provide this for a client, if you have anything specific and constructive to say, I'd be happy to contribute. Let me know what you don't like or what is wrong with it, I'll fix it when I get time.
Best,
Jacob
Comment #3
Bèr Kessels commentedI thought I was clear about the specifics that I did not like. Let it be very clear that I think the feature itself is a very valuable one, if done properly :)
* You comment out the old code, instead of removing it. If I were to commit it, I don't want the patch to have commented-out-code.
* Instead of *adding* a new block, you replace the per-vocabulary blocks with your own. I prefer to keep the per-voc blocks and *add* a new one to the set of blocks.
Bèr
Comment #4
Bèr Kessels commentedNo feedback or update for a long time. Closing old issues.
Comment #5
geek-merlinsubscribing
Comment #6
Anonymous (not verified) commentedI'd also like this feature and so have attached a patch which provides this functionality to the latest 7.x-dev version.
It simply informs users that entering a '0' as the number of tags to show will result in all tags being displayed. This works for both blocks and pages.
It's working for me; hope others can test it out to confirm.
Comment #7
MGParisi commentedNice Idea, I will try to implement it in my next patch, I am doing allot with this module!
Comment #8
Bèr Kessels commentedPlease open a pull request on github if you still want this feature.