Entity translation metadata should be stored only if the entity bundle is translatable

I don't know if this makes any difference, I have the 'body' field set as translateable through other content types, so when I set a new content type to 'enable translation' (content trans) and when I looked at the body field, under 'body field settings' it says 'Field translation: Users may translate this field. Disable translation'. so I don't know if this has something to do with making the node id go into the entity_translation table without enabling field translation on the content type.

Also, when checking in Config > entity translation, the content types do not show up indicating that they shouldn't be entity translated.

have been looking around the ET module, but am still getting used to the way drupal modules are constructed so haven't gotten very far.

the only things that have caught my eye are
line 80 in entity_translation.node.inc

/**
 * Returns whether the given node type has support for translations.
 *
 * @return
 *   Boolean value.
 */
function entity_translation_node_supported_type($type) {
  return variable_get('language_content_type_' . $type, 0) == ENTITY_TRANSLATION_ENABLED;
}

with a reference to it in entity_translation.module at line 65

 /**
 * Implements hook_entity_info().
 */
function entity_translation_entity_info() {
  $info = array();

  $info['node'] = array(
    'translation' => array(
      'entity_translation' => array(
        'class' => 'EntityTranslationNodeHandler',
        'access callback' => 'entity_translation_node_tab_access',
        'access arguments' => array(1),
        'admin theme' => variable_get('node_admin_theme'),
        'bundle callback' => 'entity_translation_node_supported_type',
        'default settings' => array(
          'default_language' => LANGUAGE_NONE,
          'hide_language_selector' => FALSE,
        ),
      ),
    ),
  );

This actually seems to be the bit that inserts the nid into entity_translation (saveTranslations). Seems that it doesn't distinguish itself between different entity types (ie. nodes, taxonomy, users). If there was a way to then check if the bundle is translatable, I would think this would solve the issue?

/**
 * Implements hook_field_attach_insert().
 */
function entity_translation_field_attach_insert($entity_type, $entity) {
  if (entity_translation_enabled($entity_type)) {
    $handler = entity_translation_get_handler($entity_type, $entity);
    $handler->initTranslations();
    $handler->saveTranslations();
  }
}

referring to my comment#4 i made an amendment that I think prevents putting the node id in the entity_translation table if the bundle is not entity translatable. this is my first ever drupal patch, so any constructive comments would be appreciated if I have done it wrong.

thanks

is this because I made the patch wrong? or was the code bad?

do I have to pull on the latest dev version and then make the patch from that?

thanks for the comments, will do.

ok, cloned from current dev version and made suggested changes. let's try this again.

Thanks for helping with the patch. Didn't really know how to progress from my last failed one, but looking at the differences, what exactly was causing it to fail so badlly? The only difference i saw was that the comment was continued on a second line... ?