font_awesome

FYI, there are 2 other projects working to get Font Awesome integrated into the existing @font-your-face module (which I maintain):

http://drupal.org/sandbox/nick_schuch/1480250
http://drupal.org/sandbox/progpapa/1529360

I've been working with both, trying to encourage more collaboration here, and would be happy to work with you as well if you're interested. That's a little more work, but I think it has a lot more potential.

Status - Needs Work

Manual Review :

You need to fix the following in font_awesome.module file :

1. You need to pass link title or taxonomy title through check_plain() before it can be put inside HTML.
2.Always use a space between the dot and the concatenated parts to improve readability.
3.Arrays should be formatted with a space separating each element (after the comma), and spaces around the => key association operator line 72 in font_awesome.module file.

I suggest you to take a look at this page:
http://ventral.org/pareview/httpgitdrupalorgsandboxispboy1834648git

Here you can check source code whether it meets drupal coding standards or not, and advise you what to change in your code. You can repeat review after your commits, and can fix those errors.

#3 sounds like needs work.

Hi!

Here is the report from manual review done of your code:
1. Please make sure each of your module file ends with a new line. Right now 'font_awesome.module' without new line in ends.
2. Add point at the end of each comment line. Please see line 20 - without stop point ('font_awesome.module').
3. Add new line after 'break' in 'case'-structure. http://drupal.org/coding-standards#controlstruct

Please also fix all issues from http://ventral.org/pareview/httpgitdrupalorgsandboxispboy1834648git

-regards

Hi!

You need to add "\n" after last line in file.

-regards

Example file:
<?php
line 1 \n
line 2 \n
....
last line \n

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

add the git url