Passing field values as contextual filters to the view is a great feature. Sometimes, the default length of 128 chars of the argument textfield is not enough since field names can be long.

I suggest to add the #maxlength attribute to the textfield with a value of 256.

CommentFileSizeAuthor
#12 views_field_view-maxlength_argument_field-1836346-10.patch554 bytescyberschorsch
#10 views_field_view-maxlength_argument_field-1836346-10.patch595 bytescyberschorsch
#7 views_field_view-maxlength_argument_field-1836346-7.patch4.19 KBcyberschorsch
#4 views_field_view-maxlength_argument_field-1836346-3.patch4.18 KBcyberschorsch
#3 views_field_view-maxlength_argument_field-1836346.patch4.18 KBcyberschorsch
#1 views_field_view-maxlength_argument_field-1836346.patch4.35 KBcyberschorsch

Comments

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new views_field_view-maxlength_argument_field-1836346.patch4.35 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, views_field_view-maxlength_argument_field-1836346.patch, failed testing.

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
StatusFileSize
new views_field_view-maxlength_argument_field-1836346.patch4.18 KB

Directories were included, re-attached

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
StatusFileSize
new views_field_view-maxlength_argument_field-1836346-3.patch4.18 KB
cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views_field_view-maxlength_argument_field-1836346-3.patch, failed testing.

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views_field_view-maxlength_argument_field-1836346-7.patch4.19 KB
damiankloip’s picture

damiankloip commented

The proposed change seems fine, not sure why the patch changes lots of other lines too though? I think you were trying to fix some whitespace, We should keep patches specific to their purpose :)

damiankloip’s picture

damiankloip commented
Status: Needs review » Needs work

http://drupalcode.org/project/views_field_view.git/commit/c2f14ed - whitespace cleaned.

So just a patch with the maxlength would be great :)

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views_field_view-maxlength_argument_field-1836346-10.patch595 bytes

Ok, here the patch just with maxlength, hope it works.

Status: Needs review » Needs work

The last submitted patch, views_field_view-maxlength_argument_field-1836346-10.patch, failed testing.

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views_field_view-maxlength_argument_field-1836346-10.patch554 bytes

Ups, corrupt patch, this one should work.

damiankloip’s picture

damiankloip commented
Status: Needs review » Fixed

Sorry for the delay, committed to 7.x-1.x!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.