Closed (fixed)
Project:
Drupal.org BDD
Version:
7.x-1.x-dev
Component:
Feature/Scenarios
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
9 Nov 2012 at 13:19 UTC
Updated:
18 Jul 2013 at 16:59 UTC
New content type and feature have been deployed on d.o yesterday. /books is now a subsection of the Marketplace. This section currently has no content, so this issue is postponed.
Once the content is there, I'll add the list of tests we need for this section.
Comments
Comment #1
tvn commentedBooks section now has content: http://drupal.org/books, so tests can be written.
I think we need 2 feature files:
marketplace_book_listing.feature
to include usual tests for the book listing content type:
- authenticated users can create and edit own book listings
- auth users can't edit other's book listings
- creation of the book listing works, data entered in all fields is saved and displayed on the page
- when created - book listing is unpublished
and
marketplace_books.feature
to include tests for the Books section itself:
- once book listing is edited by admin and published - it should appear in the list
- filtering at the top of the list should work
- sidebar block shows up and guidelines link works
Comment #2
sachin2dhoni commentedComment #3
sachin2dhoni commentedAdded the features and commited to 6.x branch.
Please check the commit log:
6.x
http://drupalcode.org/project/doobie.git/commit/48c8475
As the "/books" page is not available in 7.x so the added the @known_git7failure tag in the feature file.
7.x
http://drupalcode.org/project/doobie.git/commit/c2c5177
Comment #4
tvn commentedUpdated both files (on 6.x), edited Featured and Scenario descriptions, removed some duplicate scenarios. Modified some new scenarios and steps, and removed not needed ones.
http://drupalcode.org/project/doobie.git/commit/b09886e
marketplace_books.feature:
this seems like steps repeat each other.
Tests in this file pass for me.
marketplace_book_listing.feature:
I've used such step
Then I should not see the random "Title" linkto check that pages are unpublished when created. Apparently it does not exist yet :)
Please implement it unless there is some other existing step which can be used here.
Comment #5
sachin2dhoni commentedModified the scenarios as per comment no #4
Please check the commit log below.
6x
http://drupalcode.org/project/doobie.git/commit/6fb5d95 and http://drupalcode.org/project/doobie.git/commit/fb50daa
7x
http://drupalcode.org/project/doobie.git/commit/e4ab81d
Comment #6
tvn commentedLooks good, thanks! I guess it's 7.x now.
Comment #7
eliza411 commentedTest is failing appropriately ...