Posted by kasperg on November 9, 2012 at 1:20pm
3 followers
| Project: | Panels |
| Version: | 7.x-3.x-dev |
| Component: | Plugins - content types |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Currently Panels uses isset() for determining whether a content type should be at the top level.
Consequently setting 'top level' to FALSE makes the content type appear at top level. It's illogical and goes against code and examples in Fieldable Panel Panes.
Instead of fixing this in Fieldable Panel Panes how about using empty() instead?
The following patch implements this change.
Comments
#1
And here's the patch.
#2
I agree with this (though it's easy tow ork around by setting the value to NULL instead of FALSE).
#3
Committed and pushed.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.