CollegiateLink API

Added Drupal 7 Support

Thanks for taking the time to review my module.

You should use 7.x-1.x (or 6.x-1.x) to name your branches.
The URL for other people to access the repository should be: git clone --branch 7.x-1.x-dev http://git.drupal.org/sandbox/hashmap/1836118.git collegiatelink_api

Fixed.

There are few issues reported by automatic review at http://ventral.org/pareview.

Fixed. I did not know about this tool it is very handy.

Is there a module using this API today?

I have looked around, but I have not been able to find one.

Without an example module at least, we cannot test if the module is actually working.

Unfortunately this module cannot be used if you do not have an instance of CollegiateLink and an API key for it. I added some status pages that indicate API connection status and use a few of the module's functions. This should at least give people with a CollegiateLink instance and an API key feedback about whether their settings are correct.

Manual review:
Remove "version" from the info file, it will be added by drupal.org packaging automatically.

A bit picky as the class only contains contants but in "theory" you should add a files[] directive in the info file for CollegiateLinkApiResource.php and remove the require_once.

Fixed.

Maybe you should move API function you want to exposed in dot module file :
- collegiatelink_api_get_event_list
- collegiatelink_api_get_complete_event_list
- collegiatelink_api_get_user_position
- collegiatelink_api_get_user_membership
- etc.

and leave helper function (function _*) in *.inc file. Its just more convenient for an external module to use api function without any require once...

I appreciate the feedback, but those functions are accessible to a dependent module even though they are in a .inc file.