Here is a first shot at simplifying the overview pages. Setting as code needs review as it would be great to have some initial input. There are things todo though:

* strong tags should probably be span + CSS to be more semantically correct
* More title attributes for links

Some explanation:

* I choose grey instead of red for untranslated to give a more positive feel :)
* The bar label has it's own column but no header. It would be more correct to render it withing the bar td element, but I don't know of a good way to style that without loosing the flexibility of the current markup.

Comments

anders.fajerson’s picture

StatusFileSize
new8.38 KB

Here is a screenshot, before and after.

anders.fajerson’s picture

More explanation:
* Removed the group link, not 100% sure about that but I think it's enough to link to it on the next language page. This also (unintentionally) fixed a bug as the group linked was not wrapped in array(). It feels like the group thing is not fully explored yet (at least not by me), so it will evolve...

* Percent is rounded to whole integer (73% instead of 73.94%). Should be exact enough. I also don't display the count for number of translated strings; the percent value + number of untranslated strings gives a rough estimate, so it's redundant.

gábor hojtsy’s picture

I only looked at the screenshot, but the improvements look fine indeed.

* The bar label has it's own column but no header. It would be more correct to render it withing the bar td element, but I don't know of a good way to style that without loosing the flexibility of the current markup.

I don't understand this.

* Removed the group link, not 100% sure about that but I think it's enough to link to it on the next language page. This also (unintentionally) fixed a bug as the group linked was not wrapped in array(). It feels like the group thing is not fully explored yet (at least not by me), so it will evolve...

I agree the overview pages should be de-cluttered, but as far as I see, the groups link on the translation page itself is very much hidden, so I would not say people will find it easily.

Also "Options" should be "Operations" for consistency with Drupal.

In general, looks very good, but definitely needs some thinking still.

gábor hojtsy’s picture

I also forgot to mention that "Has suggestions" was carefully worded to indicate that the number is the sum of source strings having suggestions not the number of suggestions added to the system. If 3 strigns have 4 suggestions each, the number will be 3, not 12. I think 3 helps better estimate the data in an overview.

anders.fajerson’s picture

Status: Needs review » Needs work

Agree on all points.

I have to look into the group funtionality a bit more but it may very well be the case that it should be linked directly on this page.

I can see that I was a bit unclear on the label thing. The point was that it now has it's own column, but semantically it may be more correct to have it in the same cell as the bar it describes. It's a minor thing though.

psicomante’s picture

fajerstarter screenshot looks better. I think it could added as patch :)

pvasili@drupal.org’s picture

I too think it is necessary to add to release.
It is necessary to update for new pages.inc

function theme_l10n_community_progress_columns($sum, $translated, $has_suggestion) {
  $status = array(
...
-   'untranslated'   => array($sum - $translated - $has_suggestion, 0, t('!percent untranslated')),
+   'untranslated'   => array($sum - $translated, 0, t('!percent untranslated')),
...
pvasili’s picture

StatusFileSize
new25.12 KB
new11.57 KB

Small improvement (see http://drupal.org/files/issues/l10n_server_overview.gif):

In l10n_community.css

#l10n-community-overview td.l10n-community-status-label {
  text-align: center;  // old value - left
}

and small correct pages.inc (rename it)

gábor hojtsy’s picture

Oh, well, the textual explanation was an improvement over the number columns. Now you suggested getting number columns back is a good idea?

pvasili’s picture

Looks compactly and conveniently:)

gábor hojtsy’s picture

Yes, after you used it for a few weeks, and you know *exactly* what the numbers mean.

psicomante’s picture

lol :)

it could be a good idea creating an option for short and extended view. Extended like "before", and Short like "After".

But i think is more important manage problems of some modules, like blogtheme, which i can't extract any string.

pvasili@drupal.org’s picture

Category: task » feature
Priority: Normal » Minor

#11 Anonyms and beginners are not engaged in translation :)

gábor hojtsy’s picture

Well, the goal of this system is to get beginners to translate stuff.

pvasili’s picture

Then it is necessary to make "Export in zip" :) (http://drupal.org/node/190436)

gábor hojtsy’s picture

Status: Needs work » Fixed

I should have taken your advice to not shout untranslated stuff in red. In a commit post-alpha2, I fixed this one, so the bars are green on gray. Otherwise I implemented overview page simplifications and made the pages more human friendly, so I think we can consider this one fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.