It would be nice to have the tweet button as a ds field.

CommentFileSizeAuthor
#2 tweetbutton-1837146.patch1.16 KBjonhattan
#1 tweetbutton-1837146.patch1.07 KBjonhattan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Active » Needs review
FileSize
tweetbutton-1837146.patch1.07 KB

Patch attached with a simple integration.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
FileSize
tweetbutton-1837146.patch1.16 KB

Although it's not used at present it's better to pass in entity and entity_type to the theme function. New patch attached.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Issue summary: View changes
Status: Needs review » Closed (outdated)
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan as a volunteer commented

:'(

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood commented

@jonhattan - I'd still like to get this in but the patch didn't apply cleanly and I didn't really have time to fully test / tweak. So kinda assumed after 4 years marking as outdated was the best approach.