Sites made with Zen5 (tried it out, will probably move back to Sasson) didn't have this issue. The problem IIRC was a line break error at line 5. Deleting the template.php (I hadn't modified it) caused the site to perform as expected/validate.

Not sure exactly why this happened (a quick check on Aegir issues queue doesn't seem to bring it up), but figured I'd report it.

Comments

tsi’s picture

tsi commented

There were two empty lines after the opening <?php in SUBTHEME/template.php
I've changed that and pushed to 7.x-2.x and 7.x-3.x, but I find it really hard to believe this will cause any issue, anywhere.
Please see if that helps.

Anyway, this empty file deserves a second thought.
Zen only has commented-out code in it's STARTERKIT/template.php and a lot of documentation, do you think we should provide something of that kind in our subtheme ? I wouldn't like all the introductory info in there because I do believe Sasson's target audience should already know most of this stuff or at least know where to find it. but it might be nice to include something like the example behavior we have in SUBTHEME/scripts/SUBTHEME.js so you can copy-paste-uncomment a function that already have your theme name in it's name (inserted by drush sns)

erutan’s picture

erutan commented

I'm pretty sure it was the whitespace at the end that caused the issue.

You could just include a link to d.o documentation on template.php then list anything that Sasson does that deviates from standard functionality (ala Zen's sidebar and block templates). I'd either focus on documentation online or in theme, both have their pros and cons (in theme is there when you are in the files, online is a bit easier to sort/navigate/read intially).

erutan’s picture

erutan commented
Status: Active » Closed (fixed)

That fixed it!

  • Commit 0769b78 on 7.x-3.x, PHPSass, 7.x-3.x-Assetic, 7.x-3.x-susy by tsi: 
    issue #1837496 by erutan: Removed a line break from SUBTHEME/template....