Closed (fixed)
Project:
OG Invite People
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
11 Nov 2012 at 03:59 UTC
Updated:
28 Nov 2012 at 12:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
jerenus commentedPatch!
Comment #2
alesr commentedHi Jerenus,
The feature is welcome, of course.
Please fix two things:
- I cannot apply the patch.
I guess there are line endings problem or some other differences in your patch.
This is what I get when I try to apply.
- Change the description from:
'#description' => t('New user will be created and invited as a member to this group. One time login link is sent to invitee\'s email.(invite multiple friends at the same time, please separated by commas)')
to
'#description' => t('New user will be created and invited as a member to this group. One time login link is sent to invitee\'s email. (You can also invite multiple people at once. Simply enter their email addresses separated by commas.).')
Make those fixes and I'll commit the patch.
Thanks.
Comment #3
alesr commentedComment #4
jerenus commentedAlesr,
Here is new patch. The reason of the first problem is that the old patch is depend on the old version of the module. I have re-created the patch.
Thank you like this feature.
Jerenus
Comment #5
alesr commentedJerenus,
The patch is almost ready. Make it more bullet-proof with adding trim() when exploding email addresses with commas.
Ex. If you put this in email text field: "test1@mail.com, test2@mail.com , test3@mail.com" it will not pass the validation because of whitespaces around commas.
+ Change the label of the text field to "User email(s)" too. It will make more sense now with multiple email option in text field.
Comment #6
jerenus commentedAlesr,
Your suggestion is well. I have re-created new patch. It added your two suggestions.
Please check it again.
Thanks!
Jerenus
Comment #7
alesr commentedThanks Jerenus,
"Invite multiple friends at the same time" feature accepted and commited to dev.
Comment #8
jerenus commentedAlesr,
Thank you for your encouragement!!
Jerenus
Comment #9
alesr commentedYou are welcome ;)