Posted by lyricnz on November 11, 2012 at 11:30am
5 followers
| Project: | Rules |
| Version: | 7.x-2.x-dev |
| Component: | Rules Core |
| Category: | bug report |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
A Rules Core Integration failure appears to be genuine: the test case is sending sending email to all users with particular roles, and only checking the last one is equal to the test user. However, because the list of roles includes 'authenticated user' the email is being sent to all users including the admin user (uid 1). Sometimes, depending on SQL result ordering of a query without an order-by clause, this happens the be last, and therefore the test is failing.
Solution, remove DRUPAL_AUTHENTICATED_RID from $roles before invoking mail_to_users_of_role.
Marking as "major" just because having a test failure may prevent other patches from being suitably reviewed.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| rules-email-role-test.patch | 576 bytes | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch rules-email-role-test.patch. Unable to apply patch. See the log in the details link for more information. | View details |
Comments
#1
Well, that's embarrassing. My patch is bad, but happened to pass through blind luck. Try this.
#2
It is a deal-breaker for #1540266: Fix broken simpletests (per #10 of that thread).
#3
ops - I committed already the same as fix. Sry I should have look into the queue first. Anyway, this should be fixed now.
#4
Automatically closed -- issue fixed for 2 weeks with no activity.