Closed (fixed)
Project:
Localization update
Version:
7.x-1.0-beta3
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
11 Nov 2012 at 13:47 UTC
Updated:
26 Feb 2013 at 07:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
sutharsan commentedI agree that it could be improved, but I don't agree on the category. But thanks for the notice, I will make this more usefull in D8.
Comment #2
Jorrit commentedI would like to express my support for this change. Please make this a setting or don't log anything when both values are 0.
Comment #3
sutharsan commentedDon't count on a setting. Design for the 80%. i.e. No report when nothing happens. But D8 is first and I expect others to step-up for the backport of minor items like these.
That said, changing priority to minor.
Comment #4
Jorrit commentedYou mean that you'll make this change when a patch is supplied?
Comment #5
salvisThe fix may be a minor effort, but the nuisance is a major one. Your D7 version is still in BETA and there is no D8 version anywhere and you're deferring to D8?
I've removed the module.
Comment #6
sutharsan commentedI refer to Drupal 8 core development I'm working on #1191488: META: Integrate l10n_update functionality in core. Yes, if a patch is supplied, I will review and consider committing it. And I also disable the module when the sit is in production.
Comment #7
lambic commentedIt would be better from a performance perspective if l10n_update_cron checked the current time against the frequency before doing anything, but that requires a new variable to hold the last update time. D6 (sorry) patch attached that does that as well as only doing the watchdog if one or both of the numbers is non-zero.
Comment #8
sutharsan commentedDon't use time(), use REQUEST_TIME instead.
Patch modified and committed.