Please provide an option to disable this message. I'm getting tired of seeing this over and over again.

I started entering this as a feature request, but it's actually a bug when a background process insists to be in your face all of the time.

CommentFileSizeAuthor
#8 1837704_8.patch1.6 KBsutharsan
#7 1837704_1.patch1.45 KBlambic

Comments

sutharsan’s picture

Category: bug » feature

I agree that it could be improved, but I don't agree on the category. But thanks for the notice, I will make this more usefull in D8.

Jorrit’s picture

I would like to express my support for this change. Please make this a setting or don't log anything when both values are 0.

sutharsan’s picture

Priority: Normal » Minor

Don't count on a setting. Design for the 80%. i.e. No report when nothing happens. But D8 is first and I expect others to step-up for the backport of minor items like these.
That said, changing priority to minor.

Jorrit’s picture

You mean that you'll make this change when a patch is supplied?

salvis’s picture

That said, changing priority to minor.

The fix may be a minor effort, but the nuisance is a major one. Your D7 version is still in BETA and there is no D8 version anywhere and you're deferring to D8?

I've removed the module.

sutharsan’s picture

I refer to Drupal 8 core development I'm working on #1191488: META: Integrate l10n_update functionality in core. Yes, if a patch is supplied, I will review and consider committing it. And I also disable the module when the sit is in production.

lambic’s picture

StatusFileSize
new1.45 KB

It would be better from a performance perspective if l10n_update_cron checked the current time against the frequency before doing anything, but that requires a new variable to hold the last update time. D6 (sorry) patch attached that does that as well as only doing the watchdog if one or both of the numbers is non-zero.

sutharsan’s picture

Status: Active » Fixed
StatusFileSize
new1.6 KB
+++ l10n_update.module	(working copy)
@@ -95,10 +95,15 @@
 function l10n_update_cron() {
-  if ($frequency = variable_get('l10n_update_check_frequency', 0)) {
+  $last = variable_get('l10n_update_last_check', 0);
+  $frequency = variable_get('l10n_update_check_frequency', 0) * 24 *3600;

Don't use time(), use REQUEST_TIME instead.

Patch modified and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.