hello, on a cart page (/cart), if a qty is updated, and the button update is clicked, it does not update the cart. I tracked this down to line 967/968 in uc_cart. The following needs to be added:

'#submit' => array('uc_cart_view_form_submit'),

CommentFileSizeAuthor
#8 1837876-update-cart-submit-d7.patch1.02 KBlongwave
#5 1837876-update-cart-submit-5.patch1.06 KBlongwave
#4 1837876-update-cart-submit.patch461 byteslongwave

Comments

tr’s picture

tr commented
Status: Active » Postponed (maintainer needs more info)

Works fine for me in 6.x-2.x-dev. You should upgrade and try again, but there haven't been any changes that would affect this so I suspect you may have a contributed module installed which affects the cart page.

tr’s picture

tr commented

Oh, and there are SimpleTest test cases which check to see if the "Update" button works properly when quantities are changed. You can check the automated testing tab on the Ubercart project page to see that these tests produce the correct results, which again implies that this is something specific to your site.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Notably if you are using uc_attributes_in_cart, see #1540028: Update cart not working

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 6.x-2.9 » 6.x-2.x-dev
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1837876-update-cart-submit.patch461 bytes

I guess adding #submit consistently to all buttons on the cart page can't hurt.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 1837876-update-cart-submit-5.patch1.06 KB

We can even remove the reliance on testing $form_state['clicked_button'] by expanding this a bit further.

Status: Needs review » Needs work

The last submitted patch, 1837876-update-cart-submit-5.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

#5: 1837876-update-cart-submit-5.patch queued for re-testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
StatusFileSize
new 1837876-update-cart-submit-d7.patch1.02 KB

Committed to 6.x, patch for 7.x attached.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

Committed to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.